Replace usage of the atty crate with std::io::IsTerminal trait
#1465
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rust 1.70 stabilized the `IsTerminal` trait and the newest version of `grep-cli` crate depending on it, makes it possible to remove the unmaintained `atty` crate from the build. ``` Crate: atty Version: 0.2.14 Warning: unsound Title: Potential unaligned read Date: 2021-07-04 ID: RUSTSEC-2021-0145 URL: https://rustsec.org/advisories/RUSTSEC-2021-0145 ```
|
Thanks @nickelc, LGTM. All the CI builds passed; can you think of anything related to release that might have a problem with the requirement for a recent Rust version? |
|
I can only think of some distributions that don't provide the latest rust version yet. |
|
Right, thanks again. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NOTE: delta will require Rust 1.70 (Release 2023-06-01) with the changes.
Rust 1.70 stabilized the
IsTerminaltrait and the newest version ofgrep-clicrate depending on it, makes it possible to remove the unmaintainedattycrate from the build.