Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve binary file added output #1502

Merged

Conversation

Sondeyy
Copy link
Contributor

@Sondeyy Sondeyy commented Aug 5, 2023

Targeting: #96

If the binary file changed, it will output the Binary files a/foo and b/foo differ as before.
If the binary file got added or deleted, it will append (binary file) to the filename, print the diff header and skip the body.

Tests:

  • binary file added
  • binary file removed
  • binary file changed

@dandavison
Copy link
Owner

LGTM! Thanks very much for this work. (I tested it manually using #96 (comment))

@dandavison dandavison merged commit e0eef7d into dandavison:master Aug 5, 2023
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants