Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Look into handling the the default danger command better #447

Merged
merged 3 commits into from
Dec 24, 2017
Merged

Conversation

orta
Copy link
Member

@orta orta commented Dec 17, 2017

Fixes #177 without us having to move of commander

Also should fix the commands like danger-pr.

@DangerCI
Copy link

DangerCI commented Dec 17, 2017

Warnings
⚠️

Please add a changelog entry for your changes.

Generated by 🚫 dangerJS

@orta
Copy link
Member Author

orta commented Dec 17, 2017

Hrm, somethings up with that Dangerfile but otherwise, seems fine

screen shot 2017-12-17 at 6 46 15 pm

@orta
Copy link
Member Author

orta commented Dec 24, 2017

👍 Makes this easier to test too

@orta orta merged commit 44ea792 into master Dec 24, 2017
@orta orta deleted the defaults branch December 24, 2017 16:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Arguments aren't passed to run when using just 'danger'
2 participants