Update dependencies (#26)

* fix(build): update typescript dep and add @types/node Updated typescript to v3.x, and add node types to fix tsc build Closes #25 * build(dependencies): update dev dependencies and related configs re #25 * improvement: update dev dependencies and related configs in default template * fix: fix tooling configs not in default * build: remove typescript (not needed) and add semantic release script * build: update babel and babelrc * test: ignore built and template tests * chore: Update yeoman dependencies and lock gulp-rename yeoman relevant issue: yeoman/yo#577 gulp-rename: relevant issue: hparra/gulp-rename#84 * test: update snapshots * ci: Test on modern nodejs version * chore: Update vscode jest debug config * ci: use yarn in travis ci * fix: downgrade commitzen, didn't work with node<=10 * refactor: remove node<10 support BREAKING CHANGE: Removed support for node<10 in the generator and the generated plugins too * fix: update babel config and dependencies in template
danger · Feb 16, 2020 · ba5e6be · ba5e6be
1 parent 90d9342
commit ba5e6be
Show file tree

Hide file tree

Showing 9 changed files with 8,251 additions and 3,375 deletions.
diff --git a/.babelrc b/.babelrc
@@ -2,14 +2,17 @@
   "sourceMaps": "inline",
   "retainLines": true,
   "presets": [
-    ["env", {
-      "targets": {
-        "node": 6
+    [
+      "@babel/preset-env",
+      {
+        "targets": {
+          "node": 10
+        }
       }
-    }],
-    "stage-2"
+    ]
   ],
   "plugins": [
-    "add-module-exports"
+    "add-module-exports",
+    "@babel/plugin-proposal-class-properties"
   ]
 }
diff --git a/.travis.yml b/.travis.yml
@@ -5,12 +5,11 @@ cache:
 notifications:
   email: false
 node_js:
-  - '7'
-  - '6'
-before_script:
-  - npm prune
+  - '10'
+  - '12'
+  - node
 after_success:
-  - npm run semantic-release
+  - yarn semantic-release
 branches:
   except:
     - /^v\d+\.\d+\.\d+$/
diff --git a/.vscode/launch.json b/.vscode/launch.json
@@ -2,19 +2,17 @@
   "version": "0.2.0",
   "configurations": [
     {
-      "name": "Debug Tests",
+      "name": "Debug Jest Tests",
       "type": "node",
       "request": "launch",
-      "program": "${workspaceRoot}/node_modules/jest/bin/jest.js",
-      "stopOnEntry": false,
-      "cwd": "${workspaceRoot}",
-      "runtimeExecutable": "${workspaceRoot}/node_modules/.bin/babel-node",
       "runtimeArgs": [
-        "--nolazy"
+        "--inspect-brk",
+        "${workspaceRoot}/node_modules/.bin/jest",
+        "--runInBand"
       ],
-      "sourceMaps": true,
-      "console": "internalConsole",
-      "internalConsoleOptions": "openOnSessionStart"
+      "console": "integratedTerminal",
+      "internalConsoleOptions": "neverOpen",
+      "port": 9229
     },
     {
       "type": "node",

diff --git a/package.json b/package.json
@@ -10,16 +10,14 @@
     "yarn.lock"
   ],
   "engines": {
-    "node": ">=6.0.0"
+    "node": ">=10.0.0"
   },
   "scripts": {
-    "precommit": "lint-staged",
     "commit": "git-cz",
-    "commitmsg": "validate-commit-msg",
     "test": "jest",
     "build": "babel src -d generators --ignore test.js,__snapshots__ --copy-files",
-    "prepublish": "npm run build",
-    "semantic-release": "semantic-release pre && npm publish && semantic-release post"
+    "prepare": "npm run build",
+    "semantic-release": "semantic-release"
   },
   "keywords": [
     "yeoman",
@@ -35,47 +33,54 @@
     "url": "https://github.com/macklinu/generator-danger-plugin.git"
   },
   "devDependencies": {
-    "babel-cli": "^6.24.1",
-    "babel-jest": "^20.0.1",
+    "@babel/cli": "^7.0.0",
+    "@babel/core": "^7.0.0",
+    "@babel/plugin-proposal-class-properties": "^7.0.0",
+    "@babel/preset-env": "^7.0.0",
+    "babel-jest": "^25.1.0",
     "babel-plugin-add-module-exports": "^0.2.1",
-    "babel-preset-env": "^1.4.0",
-    "babel-preset-stage-2": "^6.24.1",
-    "commitizen": "^2.9.6",
-    "cz-conventional-changelog": "^2.0.0",
-    "husky": "^0.13.3",
-    "jest": "^20.0.1",
-    "lint-staged": "^3.4.1",
-    "prettier": "^1.3.1",
-    "semantic-release": "^6.3.6",
-    "validate-commit-msg": "^2.12.1",
-    "yeoman-assert": "^3.0.0",
-    "yeoman-test": "^1.6.0"
+    "commitizen": "^4.0.3",
+    "cz-conventional-changelog": "^3.1.0",
+    "husky": "^4.2.3",
+    "jest": "^25.1.0",
+    "lint-staged": "^10.0.7",
+    "prettier": "^1.19.1",
+    "semantic-release": "^17.0.3",
+    "validate-commit-msg": "^2.14.0",
+    "yeoman-assert": "^3.1.1",
+    "yeoman-test": "^2.1.0"
   },
   "dependencies": {
     "chalk": "^1.1.3",
     "generator-node": "^2.1.0",
     "github-url-from-username-repo": "^1.0.2",
-    "gulp-rename": "^1.2.2",
+    "gulp-rename": "1.2.2",
     "inquirer-npm-name": "^2.0.0",
-    "lodash": "^4.17.4",
+    "lodash": "^4.17.15",
     "mkdirp": "^0.5.1",
-    "yeoman-generator": "^1.1.1"
+    "yeoman-generator": "^4.5.0"
   },
   "jest": {
     "testPathIgnorePatterns": [
       "/node_modules/",
-      "<rootDir>/app/src/templates"
+      "generators",
+      "<rootDir>/src/app/templates"
     ]
   },
   "config": {
     "commitizen": {
       "path": "cz-conventional-changelog"
     }
   },
+  "husky": {
+    "hooks": {
+      "commit-msg": "validate-commit-msg",
+      "pre-commit": "lint-staged"
+    }
+  },
   "lint-staged": {
     "*.js": [
-      "prettier --single-quote --trailing-comma=es5 --no-semi --write",
-      "git add"
+      "prettier --single-quote --trailing-comma=es5 --no-semi --write"
     ]
   }
 }
diff --git a/src/app/__snapshots__/index.test.js.snap b/src/app/__snapshots__/index.test.js.snap
@@ -77,24 +77,33 @@ Object {
   },
   "description": "Danger plugin that tells you to have a fun time",
   "devDependencies": Object {
-    "babel-cli": "^6.24.1",
-    "babel-jest": "^20.0.1",
-    "babel-preset-env": "^1.4.0",
-    "commitizen": "^2.9.6",
-    "cz-conventional-changelog": "^2.0.0",
-    "husky": "^0.13.3",
-    "jest": "^20.0.1",
-    "lint-staged": "^3.4.1",
-    "prettier": "^1.3.1",
-    "semantic-release": "^6.3.6",
-    "typescript": "^2.3.2",
-    "typings-tester": "^0.2.2",
-    "validate-commit-msg": "^2.12.1",
+    "@babel/cli": "^7.0.0",
+    "@babel/core": "^7.0.0",
+    "@babel/preset-env": "^7.0.0",
+    "babel-jest": "^25.1.0",
+    "commitizen": "^4.0.3",
+    "cz-conventional-changelog": "^3.1.0",
+    "esdoc": "^1.1.0",
+    "esdoc-standard-plugin": "^1.0.0",
+    "husky": "^4.2.3",
+    "jest": "^25.1.0",
+    "lint-staged": "^10.0.7",
+    "prettier": "^1.19.1",
+    "semantic-release": "^17.0.3",
+    "typescript": "^3.6.4",
+    "typings-tester": "^0.3.2",
+    "validate-commit-msg": "^2.14.0",
   },
   "engines": Object {
-    "node": ">=4.0.0",
+    "node": ">=10.0.0",
   },
   "homepage": "https://github.com/macklinu/danger-plugin-fun-time#readme",
+  "husky": Object {
+    "hooks": Object {
+      "commit-msg": "validate-commit-msg",
+      "pre-commit": "lint-staged",
+    },
+  },
   "keywords": Array [
     "danger",
     "danger-plugin",
@@ -110,26 +119,21 @@ Object {
   },
   "main": "dist/index.js",
   "name": "danger-plugin-fun-time",
-  "optionalDependencies": Object {
-    "esdoc": "^0.5.2",
-  },
   "repository": Object {
     "type": "git",
     "url": "https://github.com/macklinu/danger-plugin-fun-time.git",
   },
   "scripts": Object {
     "build": "babel src --out-dir dist --ignore *.test.js",
     "commit": "git-cz",
-    "commitmsg": "validate-commit-msg",
     "docs": "esdoc -c .esdoc.json",
     "lint": "tslint \\"src/**/*.ts\\"",
-    "precommit": "lint-staged",
     "predocs": "rm -rf docs/",
-    "prepublish": "npm run build",
+    "prepare": "npm run build",
     "prettier": "prettier",
     "prettier-project": "npm run prettier-write -- 'src/**/*.{ts,tsx}'",
     "prettier-write": "npm run prettier -- --parser typescript --no-semi --trailing-comma es5 --write --print-width 120",
-    "semantic-release": "semantic-release pre && npm publish && semantic-release post",
+    "semantic-release": "semantic-release",
     "test": "jest",
   },
   "version": "0.0.0-development",
@@ -152,24 +156,33 @@ Object {
   },
   "description": "Danger plugin that tells you to have a fun time",
   "devDependencies": Object {
-    "@types/jest": "^19.2.4",
-    "commitizen": "^2.9.6",
-    "cz-conventional-changelog": "^2.0.0",
+    "@types/jest": "^25.1.2",
+    "@types/node": "^12.7.12",
+    "commitizen": "^4.0.3",
+    "cz-conventional-changelog": "^3.1.0",
     "danger": "*",
-    "husky": "^0.13.3",
-    "jest": "^20.0.1",
-    "lint-staged": "^3.4.1",
-    "prettier": "^1.3.1",
-    "semantic-release": "^6.3.6",
-    "ts-jest": "^20.0.0",
-    "tslint": "^5.4.3",
-    "typescript": "^2.3.2",
-    "validate-commit-msg": "^2.12.1",
+    "esdoc": "^1.1.0",
+    "esdoc-standard-plugin": "^1.0.0",
+    "husky": "^4.2.3",
+    "jest": "^25.1.0",
+    "lint-staged": "^10.0.7",
+    "prettier": "^1.19.1",
+    "semantic-release": "^17.0.3",
+    "ts-jest": "^25.1.0",
+    "tslint": "^6.0.0",
+    "typescript": "^3.6.4",
+    "validate-commit-msg": "^2.14.0",
   },
   "engines": Object {
-    "node": ">=4.0.0",
+    "node": ">=10.0.0",
   },
   "homepage": "https://github.com/macklinu/danger-plugin-fun-time#readme",
+  "husky": Object {
+    "hooks": Object {
+      "commit-msg": "validate-commit-msg",
+      "pre-commit": "lint-staged",
+    },
+  },
   "jest": Object {
     "moduleFileExtensions": Array [
       "ts",
@@ -196,31 +209,25 @@ Object {
     "*.@(ts|tsx)": Array [
       "tslint --fix",
       "npm run prettier-write --",
-      "git add",
     ],
   },
   "main": "dist/index.js",
   "name": "danger-plugin-fun-time",
-  "optionalDependencies": Object {
-    "esdoc": "^0.5.2",
-  },
   "repository": Object {
     "type": "git",
     "url": "https://github.com/macklinu/danger-plugin-fun-time.git",
   },
   "scripts": Object {
     "build": "tsc",
     "commit": "git-cz",
-    "commitmsg": "validate-commit-msg",
     "docs": "esdoc -c .esdoc.json",
     "lint": "tslint \\"src/**/*.ts\\"",
-    "precommit": "lint-staged",
     "predocs": "rm -rf docs/",
-    "prepublish": "npm run build",
+    "prepare": "npm run build",
     "prettier": "prettier",
     "prettier-project": "npm run prettier-write -- 'src/**/*.{ts,tsx}'",
     "prettier-write": "npm run prettier -- --parser typescript --no-semi --trailing-comma es5 --write --print-width 120",
-    "semantic-release": "semantic-release pre && npm publish && semantic-release post",
+    "semantic-release": "semantic-release",
     "test": "jest",
   },
   "types": "dist/index.d.ts",

diff --git a/src/app/defaults.js b/src/app/defaults.js
@@ -2,39 +2,42 @@ export const defaultPackageJson = {
   version: '0.0.0-development',
   main: 'dist/index.js',
   scripts: {
-    precommit: 'lint-staged',
     commit: 'git-cz',
-    commitmsg: 'validate-commit-msg',
     build: 'babel src --out-dir dist --ignore *.test.js',
     test: 'jest',
     predocs: 'rm -rf docs/',
     docs: 'esdoc -c .esdoc.json',
-    prepublish: 'npm run build',
-    'semantic-release': 'semantic-release pre && npm publish && semantic-release post',
+    prepare: 'npm run build',
+    'semantic-release': 'semantic-release',
   },
   license: 'MIT',
   engines: {
-    node: '>=4.0.0',
+    node: '>=10.0.0',
   },
   devDependencies: {
-    commitizen: '^2.9.6',
-    'cz-conventional-changelog': '^2.0.0',
-    husky: '^0.13.3',
-    jest: '^20.0.1',
-    'lint-staged': '^3.4.1',
-    prettier: '^1.3.1',
-    'semantic-release': '^6.3.6',
-    typescript: '^2.3.2',
-    'validate-commit-msg': '^2.12.1',
-  },
-  optionalDependencies: {
-    esdoc: '^0.5.2',
+    commitizen: '^4.0.3',
+    'cz-conventional-changelog': '^3.1.0',
+    esdoc: '^1.1.0',
+    'esdoc-standard-plugin': '^1.0.0',
+    husky: '^4.2.3',
+    jest: '^25.1.0',
+    'lint-staged': '^10.0.7',
+    prettier: '^1.19.1',
+    'semantic-release': '^17.0.3',
+    typescript: '^3.6.4',
+    'validate-commit-msg': '^2.14.0',
   },
   config: {
     commitizen: {
       path: 'cz-conventional-changelog',
     },
   },
+  husky: {
+    hooks: {
+      'commit-msg': 'validate-commit-msg',
+      'pre-commit': 'lint-staged',
+    },
+  },
   'lint-staged': {
     '*.js': [
       'prettier --single-quote --trailing-comma=all --no-semi --write',