New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use Version struct for danger swift version #588
base: master
Are you sure you want to change the base?
Conversation
|
||
struct InlineDependenciesFinder { | ||
let fileReader: FileReading | ||
let config: ScriptManager.Config | ||
|
||
init(fileReader: FileReading = FileReader(), | ||
config: ScriptManager.Config) { | ||
config: ScriptManager.Config) | ||
{ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
⚠️ Opening braces should be preceded by a single space and on the same line as the declaration. (opening_brace
)
self.fileReader = fileReader | ||
self.config = config | ||
} | ||
|
||
func resolveInlineDependencies(fromPath path: String, | ||
dangerSwiftVersion: String) throws -> [InlineDependency] { | ||
dangerSwiftVersion: Version) throws -> [InlineDependency] | ||
{ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
⚠️ Opening braces should be preceded by a single space and on the same line as the declaration. (opening_brace
)
@@ -37,7 +40,8 @@ struct InlineDependenciesFinder { | |||
|
|||
result.append(InlineDependency(url: url, major: majorVersion)) | |||
} else if let firstCharacter = line.unicodeScalars.first, | |||
!CharacterSet.alphanumerics.contains(firstCharacter) { | |||
!CharacterSet.alphanumerics.contains(firstCharacter) | |||
{ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
⚠️ Opening braces should be preceded by a single space and on the same line as the declaration. (opening_brace
)
@@ -10,7 +11,8 @@ public struct ScriptManager { | |||
|
|||
public init(prefix: String = "package: ", | |||
file: String = "Dangerplugins", | |||
major: String = "~> ") { | |||
major: String = "~> ") | |||
{ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
⚠️ Opening braces should be preceded by a single space and on the same line as the declaration. (opening_brace
)
@@ -36,7 +39,8 @@ public struct ScriptManager { | |||
public init(folder: String, | |||
dangerSwiftVersion: String, | |||
packageManager: PackageManager, | |||
logger: Logger) throws { | |||
logger: Logger) throws | |||
{ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
⚠️ Opening braces should be preceded by a single space and on the same line as the declaration. (opening_brace
)
@@ -215,7 +223,8 @@ public final class Script { | |||
func executeSwiftCommand(_ command: String, | |||
onFolder folder: String? = nil, | |||
arguments: [String] = [], | |||
executor: ShellExecutor) throws -> String { | |||
executor: ShellExecutor) throws -> String | |||
{ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
⚠️ Opening braces should be preceded by a single space and on the same line as the declaration. (opening_brace
)
Generated by 🚫 Danger Swift against db1e893 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, except lint warnings
No description provided.