Parse labels with emojis #285
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dangoslen
commented
Apr 11, 2024
| // Each match may are may not have a trailing comma (,?). If one exists, it is removed before appending it to the list | ||
| const regex = new RegExp(/([\w\s-\/+\?;\[\]\(\)]+,?)/, 'g') | ||
| const regex = new RegExp(/([\w\s-/+?;:[\]()]+,?)/, 'g') |
There was a problem hiding this comment.
@mathomp4 You were spot on!
There was a problem hiding this comment.
Oof. Glad I didn't try. I would have messed up that regex for sure. 😄
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes issue #284 by adding
:to the label extractor Regex. This PR also simplifies the Regex syntax and adds better comments to the Regex.