Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support ESLint 8.x #108

Merged
merged 1 commit into from Nov 16, 2021
Merged

Conversation

MichaelDeBoey
Copy link
Contributor

@MichaelDeBoey MichaelDeBoey commented Aug 29, 2021

ESLint v8.0.0 is released 馃帀

devDependency compatibility with ESLint 8:


BREAKING CHANGE: Requires Node@^12.22.0 || ^14.17.0 || >=16.0.0

Closes #107

@benkimpel
Copy link
Collaborator

@MichaelDeBoey Thanks for the PR. Need any help? (I know it's still in Draft, but couldn't help taking a look.)

@MichaelDeBoey
Copy link
Contributor Author

@benkimpel I think I'm mostly waiting on the devDeps to support ESLint 8.x now 馃

@benkimpel
Copy link
Collaborator

@benkimpel I think I'm mostly waiting on the devDeps to support ESLint 8.x now thinking

Great! 馃憤

@dangreenisrael
Copy link
Owner

Hey @MichaelDeBoey, you have some linting errors

@MichaelDeBoey
Copy link
Contributor Author

@dangreenisrael Should I just ignore no-shadow rule on these lines?
They're reporting that i's already there on their own line

18:19  error  'StatementType' is already declared in the upper scope on line 18 column 19  no-shadow
40:19  error  'PaddingType' is already declared in the upper scope on line 40 column 19    no-shadow

@dangreenisrael
Copy link
Owner

dangreenisrael commented Nov 10, 2021

I'm cool with that. Will you just add a comment in the code explaining why we are making an exception to the rule?

package.json Show resolved Hide resolved
src/rules/padding.ts Outdated Show resolved Hide resolved
BREAKING CHANGE: Requires Node@^12.22.0 || ^14.17.0 || >=16.0.0
Copy link
Collaborator

@benkimpel benkimpel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank you! 馃檹

@benkimpel
Copy link
Collaborator

@MichaelDeBoey I want to give @dangreenisrael a chance to review, but this will probably merge tomorrow.

@benkimpel
Copy link
Collaborator

@MichaelDeBoey I want to give @dangreenisrael a chance to review, but this will probably merge tomorrow.

I'm going to take Dan's comment as tacit approval for a merge. He'll have to trigger the release to npm, though.

@benkimpel benkimpel merged commit 6f67ec6 into dangreenisrael:master Nov 16, 2021
@MichaelDeBoey MichaelDeBoey deleted the eslint-8 branch November 17, 2021 09:25
@MichaelDeBoey
Copy link
Contributor Author

@dangreenisrael Can you please trigger the release?

@dangreenisrael
Copy link
Owner

3.1.0 has been shipped. Thanks so much for your work @MichaelDeBoey!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support ESLint 8.x
4 participants