Change API and structs to camelCase #4386
Draft
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes all the project's structs and API inputs and outputs from the old
PascalCase
format to the newcamelCase
format. At the moment the clients support both but that won't be a thing forever.I haven't had the time to fully test this, but at least the basic things work. There may be some things missing, and I still need to review what we store in the db to make sure that there aren't any backwards compat issues.
This might also cause problems with other pending PRs so we can wait to merge it until they are dealt with.
Some fields that have special casing:
OTP
in/accounts/verify-otp
, as that's what the clients send. That said we also checkotp
Keys
andNfc
in yubikey, this is for backwards compat with older values stored on the server, now we serialize new versions tokeys
andnfc
.AttestationObject
andclientDataJson
in webauthn, as that's what the clients send. This is a bigger annoyance as it complicates the use of the webauthn crate.camelCase
.