Convert x,y to numbers #531
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Just throwing it here if someone will fork it and will take it to maintain it for all of us. If you start with the snapshot test in `test/graph/graph.snapshot.spec.js`, you will see the snapshot is weird. Debug it, and you will see the coordinates are `string`s. First of all, it is not good. The bug is in these lines: https://github.com/CheckmarxDev/fusion-react-d3-graph/blob/master/src/components/graph/graph.helper.js#L543 ```javascript x1 += sourceNodeSize * directionVector.x; y1 += sourceNodeSize * directionVector.y; ``` If the `x1` and `y1` are `string`, adding a `number` to them will concatenate the number to the end of the string, and this is why you see coords like `402.6029494893985485,200-4.685309080917388` in the snapshot.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just throwing it here if someone will fork it and will take it to maintain it for all of us.
If you start with the snapshot test in
test/graph/graph.snapshot.spec.js, you will see the snapshot is weird.Debug it, and you will see the coordinates are
strings. First of all, it is not good.The bug is in these lines:
https://github.com/CheckmarxDev/fusion-react-d3-graph/blob/master/src/components/graph/graph.helper.js#L543
If the
x1andy1arestring, adding anumberto them will concatenate the number to the end of the string, and this is why you see coords like402.6029494893985485,200-4.685309080917388in the snapshot.