Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WorkflowExecutor is not sending LifeCycleEvents.WorkflowCompleted when Workflow is marked with IStepBuilder.EndWorkflow #1097

Open
Hau-Bold opened this issue Oct 21, 2022 · 1 comment · May be fixed by #1201
Open

WorkflowExecutor is not sending LifeCycleEvents.WorkflowCompleted when Workflow is marked with IStepBuilder.EndWorkflow #1097

Hau-Bold opened this issue Oct 21, 2022 · 1 comment · May be fixed by #1201

Comments

@Hau-Bold
Copy link

WorkflowExecutor is not sending LifeCycleEvents.WorkflowCompleted when Workflow is marked with IStepBuilder.EndWorkflow

just check https://github.com/danielgerlag/workflow-core/blob/master/src/WorkflowCore/Services/WorkflowExecutor.cs

https://github.com/danielgerlag/workflow-core/blob/master/src/WorkflowCore/Primitives/EndStep.cs

returns

ExecutionPipelineDirective .EndWorkflow

=> WorkflowExecutor .InitializeStep returns fals and the Event is not fired.

Additional, I think the status of the worklfow is set to early to complete in line 259.

You may request the value from execitionContext when middlewareRunner is executed.
@vladimir-kovalyuk
Copy link

vladimir-kovalyuk commented Nov 1, 2022 •
edited

#836

@danielgerlag keeps ignoring this issue.

I'm open to use alternative framework once comes.

@mamidenn mamidenn linked a pull request Aug 12, 2023 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix sending of workflow completed event mamidenn/workflow-core
2 participants
@vladimir-kovalyuk @Hau-Bold