Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix sending of workflow completed event #1201

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

mamidenn
Copy link
Contributor

@mamidenn mamidenn commented Aug 12, 2023

Describe the change
As described in #1097 a workflow that ends in an EndStep does not lead to the WorkflowCompleted LifeCycleEvent being published because DetermineNextExecutionTime returns too early.
This PR remedies that by sending the event also in case of an early return from DetermineNextExecutionTime.

Describe your implementation or design
Extracted publishing of WorkflowCompleted into a separate method and added a call to that function before the early return if workflow is completed.

Tests
Yes, added a failing unit test that is green after the implementation is changed.

Breaking change
No

Additional context

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants