Added condition so the resolved value is only cast to string and pars… #917
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ed to an enum if it is not directly assignable.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ed to an enum if it is not directly assignable.
Describe the change
A clear and concise description of what the change is. Any PR submitted without a description of the change will not be reviewed.
Fixed a condition in the DefinitionLoader that made it so that inputs could not be assigned from enums that matched the type of the property to assign to.
Describe your implementation or design
How did you go about implementing the change?
Added a condition, similar to that in the else statement underneath to cover the case when the enum object is directly assignable to the
stepProperty.Tests
Did you cover your changes with tests?
No, the DefinitionLoader class is not really built in a testable way. Without modifying the accessibility levels of the methods in DefinitionLoader, I don't really feel comfortable writing new unit tests for the class. Besides, the class has terrible test coverage already.
Breaking change
Do you changes break compatibility with previous versions?
Would not think so.
Additional context
Any additional information you'd like to provide?
See issue #916 .