Skip to content

Commit

Permalink
tools: enable no-empty ESLint rule
Browse files Browse the repository at this point in the history
Refs: https://eslint.org/docs/rules/no-empty

PR-URL: nodejs#41831
Backport-PR-URL: nodejs#42160
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
  • Loading branch information
Trott authored and danielleadams committed Mar 4, 2022
1 parent 783f8ef commit ac8537d
Show file tree
Hide file tree
Showing 3 changed files with 0 additions and 3 deletions.
1 change: 0 additions & 1 deletion .eslintrc.js
Expand Up @@ -295,7 +295,6 @@ module.exports = {
'valid-typeof': ['error', { requireStringLiterals: true }],

// ESLint recommended rules that we disable
'no-empty': 'off',
'no-inner-declarations': 'off',

// JSDoc recommended rules that we disable
Expand Down
1 change: 0 additions & 1 deletion benchmark/.eslintrc.yaml
Expand Up @@ -5,6 +5,5 @@ env:
es6: true

rules:
no-empty: error
no-var: error
prefer-arrow-callback: error
1 change: 0 additions & 1 deletion test/.eslintrc.yaml
Expand Up @@ -6,7 +6,6 @@ env:

rules:
multiline-comment-style: ["error", "separate-lines"]
no-empty: error
no-var: error
prefer-const: error
symbol-description: off
Expand Down

0 comments on commit ac8537d

Please sign in to comment.