🤖 Merge PR DefinitelyTyped#46383 [react-select] Fix animatedScrollTo …

…method by @Methuselah96 * Fix animatedScrollTo method * Add test * Add change * Add file * Fix
danielrearden · Sep 22, 2020 · ed8bf83 · ed8bf83
1 parent ee8e095
commit ed8bf83
Show file tree

Hide file tree

Showing 3 changed files with 11 additions and 3 deletions.
diff --git a/types/react-select/src/utils.d.ts b/types/react-select/src/utils.d.ts
@@ -68,10 +68,10 @@ export function getScrollParent(element: React.Ref<any>): Element;
 // ------------------------------
 
 export function animatedScrollTo(
-  element: Element,
+  element: HTMLElement | typeof window,
   to: number,
-  duration: number,
-  callback: (element: Element) => void
+  duration?: number,
+  callback?: (element: HTMLElement | typeof window) => void
 ): void;
 
 // Scroll Into View

diff --git a/types/react-select/test/animatedScrollTo.ts b/types/react-select/test/animatedScrollTo.ts
@@ -0,0 +1,7 @@
+import { animatedScrollTo } from "react-select/src/utils";
+
+// Inspired by https://github.com/JedWatson/react-select/blob/master/docs/App/PageNav.js#L70
+const el = document.querySelector<HTMLElement>('#test');
+if (el && el.offsetTop) {
+    animatedScrollTo(window, el.offsetTop);
+}
diff --git a/types/react-select/tsconfig.json b/types/react-select/tsconfig.json
@@ -20,6 +20,7 @@
     },
     "files": [
         "index.d.ts",
+        "test/animatedScrollTo.ts",
         "test/data.ts",
         "test/styled-components.tsx",
         "test/AtlaskitDummy.ts",