Conversation
New dependency changes detected. Learn more about Socket for GitHub ↗︎ 👍 No new dependency issues detected in pull request Bot CommandsTo ignore an alert, reply with a comment starting with Pull request alert summary
📊 Modified Dependency Overview:
🚮 Removed packages: @vitest/coverage-c8@0.30.1, @vitest/ui@0.30.0 |
e925879
to
35fbf28
Compare
Would be great to use Vitest 0.31 with this. Hope this gets merged soon. |
I'm not sure why the tests failed honestly, so @danielroe might have something to add. You can still use 0.31, just manually add |
Thanks. Did had to force it though. But the tests don't fail right? They're still waiting for approval to run. |
Think they failed first couple times, the lock file was out of sync and then something else I think. |
The issue is that vitest 0.31 breaks the component mocking feature of this library and we're waiting for that to be fixed upstream. |
@danielroe is that still the case? I see vitest-dev/vitest#3438 was merged. Wondering if it's safe to unpin the vitest package here. |
I'm afraid there are other problems in the latest |
The issues I have is that there is a false positive detection of a circular dependency bug in vitest |
I appreciate the PR - but let's track in #157. It requires more work to get things working with the latest version of Vitest.... |
Attempt to fix https://github.com/danielroe/nuxt-vitest/issues/171
Does this look like it should solve our issues?