Skip to content
This repository has been archived by the owner on Dec 19, 2023. It is now read-only.

Bump vitest and vitest c8 coverage #185

Closed
wants to merge 3 commits into from

Conversation

silverbackdan
Copy link

Attempt to fix https://github.com/danielroe/nuxt-vitest/issues/171
Does this look like it should solve our issues?

@socket-security
Copy link

socket-security bot commented May 25, 2023

New dependency changes detected. Learn more about Socket for GitHub ↗︎


👍 No new dependency issues detected in pull request

Bot Commands

To ignore an alert, reply with a comment starting with @SocketSecurity ignore followed by a space separated list of package-name@version specifiers. e.g. @SocketSecurity ignore foo@1.0.0 bar@* or ignore all packages with @SocketSecurity ignore-all

Pull request alert summary
Issue Status
Install scripts ✅ 0 issues
Native code ✅ 0 issues
Bin script shell injection ✅ 0 issues
Unresolved require ✅ 0 issues
Invalid package.json ✅ 0 issues
HTTP dependency ✅ 0 issues
Git dependency ✅ 0 issues
Potential typo squat ✅ 0 issues
Known Malware ✅ 0 issues
Telemetry ✅ 0 issues
Protestware/Troll package ✅ 0 issues

📊 Modified Dependency Overview:

➕ Added Package Capability Access +/- Transitive Count Publisher
@nuxt/kit@3.5.1 None +44 danielroe
⬆️ Updated Package Version Diff Added Capability Access +/- Transitive Count Publisher
unenv@1.5.1 1.4.1...1.5.1 network, environment +1/-0 pi0
vue-router@4.2.1 4.2.0...4.2.1 None +1/-1 posva

🚮 Removed packages: @vitest/coverage-c8@0.30.1, @vitest/ui@0.30.0

@TECH7Fox
Copy link

Would be great to use Vitest 0.31 with this. Hope this gets merged soon.

@silverbackdan
Copy link
Author

I'm not sure why the tests failed honestly, so @danielroe might have something to add. You can still use 0.31, just manually add vitest-environment-nuxt as well into your project pnpm i -D vitest-environment-nuxt should work, I'm using it and have vitest 0.31 installed.

@TECH7Fox
Copy link

TECH7Fox commented May 25, 2023

Thanks. Did had to force it though. But the tests don't fail right? They're still waiting for approval to run.

@silverbackdan
Copy link
Author

Think they failed first couple times, the lock file was out of sync and then something else I think.

Copy link
Owner

The issue is that vitest 0.31 breaks the component mocking feature of this library and we're waiting for that to be fixed upstream.

@marr
Copy link

marr commented Jun 12, 2023

@danielroe is that still the case? I see vitest-dev/vitest#3438 was merged. Wondering if it's safe to unpin the vitest package here.

@danielroe
Copy link
Owner

I'm afraid there are other problems in the latest vitest - see https://github.com/danielroe/nuxt-vitest/actions/runs/5247483708/jobs/9477713633.

@silverbackdan
Copy link
Author

The issues I have is that there is a false positive detection of a circular dependency bug in vitest 0.30.1, 0.32 has the issue as linked by @danielroe... however I've found a sweet spot version - 0.31.1 - everything is working there, but not 0.31.2 to 0.31.4 either.

@danielroe
Copy link
Owner

I appreciate the PR - but let's track in #157. It requires more work to get things working with the latest version of Vitest....

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants