Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed a bug when handling non-cached range responses that aren't honored by the server. #153

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

clangen
Copy link

@clangen clangen commented Jun 4, 2017

Here's my use case: I'm playing music against a server that is unable to satisfy range requests. Instead, it returns an HTTP 200 and the full body. At this point, if the response is not in the cache, AndroidVideoCache ignores the offset and starts returning data from the beginning of the stream.

I realize this pull request may not be accepted because:

  1. I'm not super familiar with the code base; the fix may be in the wrong spot.
  2. I took a look at the test suite, but I'm not quite sure how to test this particular case. If you have an idea, let me know.

At any rate, I wanted you to be aware of the issue with a potential fix.

server responds with with an HTTP 200 (not 206), and the response has
not yet been cached.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant