Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

uses class extends, code restructure need major release #10

Merged
merged 5 commits into from
Aug 18, 2018

Conversation

uniibu
Copy link
Contributor

@uniibu uniibu commented May 24, 2018

This is in relation to #9

Major/Breaking changes:

  • No longer mutates the original pg classes pg.Pool and pg.Client
  • Uses class extends whenever possible.
  • To use pg-extra's helper methods, user's must initialize it using new pg.extra.Client or new pg.extra.Pool
  • In relation to above, pg.Client and pg.Pool now returns to their respective original instances.
  • removal of parse-url since pg can accept { connectionString }

Minor changes:

  • Restructuring of codes.
  • Renaming of files using camelCase
  • Update of test files to use pg.extra.Client and pg.extra.Pool
  • Adds nodejs v8 and v10 to travis test.

Passes travis tests.

Note: This does not update package.json version and readme.md. So if merged, you will have to update them accordingly. :)

@danneu
Copy link
Owner

danneu commented Aug 2, 2018

Awesome! I won't be able to review this for another few weeks. Currently traveling.

Thanks for the work!

@danneu danneu merged commit 500f098 into danneu:master Aug 18, 2018
@danneu
Copy link
Owner

danneu commented Aug 18, 2018

Merged. Now I need to sync the readme and prep a major release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants