unparametrized root models serializer generation bug fixed. Affected by

pydantic/pydantic#7119 change.
dapper91 · Aug 17, 2023 · ac04b34 · ac04b34
1 parent 8ad6b6c
commit ac04b34
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 4 deletions.
diff --git a/examples/snippets/model_root_type.py b/examples/snippets/model_root_type.py
@@ -10,8 +10,8 @@ class Socials(RootXmlModel, tag='socials'):
     root: List[HttpUrl] = element(tag='social')
 
 
-class Contacts(RootXmlModel[Socials], tag='contacts'):
-    pass
+class Contacts(RootXmlModel, tag='contacts'):
+    root: Socials
 # [model-end]
 
 

diff --git a/pydantic_xml/model.py b/pydantic_xml/model.py
@@ -269,8 +269,15 @@ def __build_serializer__(cls) -> None:
         if cls is BaseXmlModel:
             return
 
-        if cls.__pydantic_generic_metadata__['parameters']:  # checks that all generic parameters are provided
-            return
+        # checks that all generic parameters are provided
+        if cls.__pydantic_root_model__:
+            if cls.__pydantic_generic_metadata__['parameters'] and not cls.__annotations__.get('root'):
+                cls.__xml_serializer__ = None
+                return
+        else:
+            if cls.__pydantic_generic_metadata__['parameters']:
+                cls.__xml_serializer__ = None
+                return
 
         if config.REGISTER_NS_PREFIXES and cls.__xml_nsmap__:
             utils.register_nsmap(cls.__xml_nsmap__)