Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates dapr/dapr to v1.12 #1342

Merged

Conversation

JoshVanL
Copy link
Contributor

@JoshVanL JoshVanL commented Sep 15, 2023

Updates dapr/dapr to 1.12

PR currently points to the unreleased tag v1.12.0-rc2

/cc @mukundansundar

@JoshVanL JoshVanL requested review from a team as code owners September 15, 2023 12:23
@codecov
Copy link

codecov bot commented Sep 15, 2023

Codecov Report

Patch coverage: 32.00% and project coverage change: -0.13% ⚠️

Comparison is base (41f3240) 22.95% compared to head (195f539) 22.82%.

Additional details and impacted files
@@               Coverage Diff                @@
##           release-1.12    #1342      +/-   ##
================================================
- Coverage         22.95%   22.82%   -0.13%     
================================================
  Files                40       40              
  Lines              4697     4701       +4     
================================================
- Hits               1078     1073       -5     
- Misses             3542     3550       +8     
- Partials             77       78       +1     
Files Changed Coverage Δ
pkg/kubernetes/client.go 4.76% <ø> (ø)
pkg/kubernetes/configuration.go 0.00% <0.00%> (ø)
pkg/kubernetes/mtls.go 0.00% <0.00%> (ø)
pkg/kubernetes/renew_certificate.go 0.00% <0.00%> (ø)
pkg/kubernetes/configurations.go 53.08% <66.66%> (-5.59%) ⬇️
pkg/kubernetes/annotator.go 70.52% <100.00%> (-0.34%) ⬇️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

go.mod Outdated
Comment on lines 29 to 33
k8s.io/api v0.26.3
k8s.io/apiextensions-apiserver v0.26.3
k8s.io/apimachinery v0.26.3
k8s.io/cli-runtime v0.26.3
k8s.io/client-go v0.26.3
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We still want to support 26.2 for this release can be updated in the next release . There is an issue tracking it.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have pushed a commit to update the runtime to rc.2 and have reverted the k8s package update in this commit - a139d39

let me know what you think ? @JoshVanL @mukundansundar

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@pravinpushkar please try not to push to authors branches, and instead favor code review or PRing to their branch 🙂

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@JoshVanL Sure, thought you will not be able to look into it until my night time. So, was only trying to fast pace the process for RC cut.

@pravinpushkar
Copy link
Contributor

pravinpushkar commented Sep 18, 2023

Should we merge the #1331 to this PR ?

Should we include the upgrade path changes to this PR as well ?

We also need to point it to runtime RC.2.

@pravinpushkar pravinpushkar changed the base branch from master to release-1.12 September 18, 2023 05:33
Signed-off-by: joshvanl <me@joshvanl.dev>
@JoshVanL JoshVanL marked this pull request as draft September 18, 2023 11:27
@JoshVanL JoshVanL closed this Sep 18, 2023
@JoshVanL JoshVanL reopened this Sep 18, 2023
Signed-off-by: joshvanl <me@joshvanl.dev>
Signed-off-by: joshvanl <me@joshvanl.dev>
artursouza
artursouza previously approved these changes Sep 18, 2023
Signed-off-by: joshvanl <me@joshvanl.dev>
Signed-off-by: joshvanl <me@joshvanl.dev>
Signed-off-by: joshvanl <me@joshvanl.dev>
Signed-off-by: joshvanl <me@joshvanl.dev>
Signed-off-by: joshvanl <me@joshvanl.dev>
Signed-off-by: joshvanl <me@joshvanl.dev>
@JoshVanL JoshVanL marked this pull request as ready for review September 20, 2023 11:07
@mukundansundar mukundansundar merged commit 0c99afb into dapr:release-1.12 Sep 20, 2023
28 checks passed
nikitasarawgi pushed a commit to nikitasarawgi/dapr-cli that referenced this pull request Oct 27, 2023
* Updates the Dapr version to v1.12.0-rc.1

Signed-off-by: joshvanl <me@joshvanl.dev>

* Use correct rc tag name

Signed-off-by: joshvanl <me@joshvanl.dev>

* Fix string match on `HTTP server is running on port x`

Signed-off-by: joshvanl <me@joshvanl.dev>

* Fix error string check for `internal gRPC server`

Signed-off-by: joshvanl <me@joshvanl.dev>

* Update dapr/dapr to 1.12.0-rc.3

Signed-off-by: joshvanl <me@joshvanl.dev>

* Rolling restart the sidecar injector during a restart

Signed-off-by: joshvanl <me@joshvanl.dev>

* Linting

Signed-off-by: joshvanl <me@joshvanl.dev>

* Fix string matching on dapr app output logs

Signed-off-by: joshvanl <me@joshvanl.dev>

* Increase e2e tests `20m` -> `25m`

Signed-off-by: joshvanl <me@joshvanl.dev>

---------

Signed-off-by: joshvanl <me@joshvanl.dev>
Signed-off-by: Nikita Sarawgi <sarawgi.nikita@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants