Add --run-file support for stdin #1364
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
NOTE: I haven't added tests to this as it wasn't clear to me how I would set up stdin in a test (although the code is pretty simple) |
stuartleeks
force-pushed
the
stuartle/run-file-stdin
branch
from
b3f2019
to
9a2a66b
Compare
If the run-file argument is speficied as '-', read the config file from stdin Signed-off-by: Stuart Leeks <stuartle@microsoft.com>
stuartleeks
force-pushed
the
stuartle/run-file-stdin
branch
from
9a2a66b
to
5a04ffd
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1364 +/- ##
=======================================
Coverage 22.76% 22.76%
=======================================
Files 40 40
Lines 4713 4713
=======================================
Hits 1073 1073
Misses 3562 3562
Partials 78 78 ☔ View full report in Codecov by Sentry. |
pravinpushkar
approved these changes
Nov 14, 2023
There was a problem hiding this comment.
LGTM
@stuartleeks We might want to include this way of running in our docs too.
|
@pravinpushkar -I'm happy to look at a PR to the docs to include this |
7 tasks
|
I've created a PR for the related docs update: dapr/docs#3872 Let me know if there's anything else needed to merge this PR - thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Update
runcommand so that if the--run-fileargument is speficied as-the config file is read from stdin.This is the same idea as
kubectl apply -f -and allows the configuration to be generated by some other means (e.g. by applying values to a template version of the file).Issue reference
We strive to have all PR being opened based on an issue, where the problem or feature have been discussed prior to implementation.
Please reference the issue this PR will close: #[issue number]
Checklist
Please make sure you've completed the relevant tasks for this PR, out of the following list: