Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consul name resolution - introduce in memory cache using blocking queries #934

Closed
a-elsheikh opened this issue Jun 10, 2021 · 2 comments
Closed
Labels
pinned Issue does not get stale
Milestone

Comments

@a-elsheikh
Copy link
Contributor

a-elsheikh commented Jun 10, 2021

The consul name resolution component currently makes a roundtrip call to the agent each time it resolves an app id, this can be improved by maintaining an in memory cache of the resolved service nodes combined with the blocking query feature exposed by the consul api - https://www.consul.io/api-docs/features/blocking

credit to @pkedy for the suggestion

PR - #963

@dapr-bot
Copy link
Collaborator

This issue has been automatically marked as stale because it has not had activity in the last 30 days. It will be closed in the next 7 days unless it is tagged (pinned, good first issue, help wanted or triaged/resolved) or other activity occurs. Thank you for your contributions.

@dapr-bot dapr-bot added the stale label Jul 28, 2021
@dapr-bot
Copy link
Collaborator

dapr-bot commented Aug 4, 2021

This issue has been automatically closed because it has not had activity in the last 37 days. If this issue is still valid, please ping a maintainer and ask them to label it as pinned, good first issue, help wanted or triaged/resolved. Thank you for your contributions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pinned Issue does not get stale
Projects
None yet
Development

No branches or pull requests

4 participants