[nameresolution/consul] resolver caching and service deregister #3830
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Abdulaziz Elsheikh <abdulaziz.elsheikh@gmail.com>
a-elsheikh
changed the title
|
FYI @ItalyPaleAle |
msfussell
reviewed
Oct 19, 2023
daprdocs/content/en/reference/components-reference/supported-name-resolution/setup-nr-consul.md
Outdated
Show resolved
Hide resolved
daprdocs/content/en/reference/components-reference/supported-name-resolution/setup-nr-consul.md
Outdated
Show resolved
Hide resolved
daprdocs/content/en/reference/components-reference/supported-name-resolution/setup-nr-consul.md
Outdated
Show resolved
Hide resolved
daprdocs/content/en/reference/components-reference/supported-name-resolution/setup-nr-consul.md
Outdated
Show resolved
Hide resolved
Co-authored-by: Mark Fussell <markfussell@gmail.com> Signed-off-by: Abdulaziz Elsheikh <abdulaziz.elsheikh@gmail.com>
hey @msfussell - as per my conversations with @berndverst the aim is to get components-contrib/pr#3121 into v1.13 so this PR is inline with that |
|
Stale PR, paging all reviewers |
|
Stale PR, paging all reviewers |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Updates to the nameresolution/consul component documentation to reflect the changes made in components-contrib/pr#3121 - namely, resolver caching and service deregister
Issue reference
components-contrib/issue#934