Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added local component which scans processes every 30 seconds and cach… #1455

Closed

Conversation

jigargandhi
Copy link
Member

Description

Created a local name resolution component that does parsing of command line arguments to daprd/daprd.exe to identify different dapr instances.

Issue reference

We strive to have all PR being opened based on an issue, where the problem or feature have been discussed prior to implementation.

Please reference the issue this PR will close: dapr/dapr#3256

PR review comments from #1340 are fixed here.

Checklist

Please make sure you've completed the relevant tasks for this PR, out of the following list:

  • Code compiles correctly
  • Created/updated tests
  • Extended the documentation / Created issue in the https://github.com/dapr/docs/ repo: dapr/docs#[issue number]

…es info

Signed-off-by: jigargandhi <jigarr.gandhi@gmail.com>
@yaron2
Copy link
Member

yaron2 commented Feb 21, 2022

@jigargandhi can you please resolve conflicts?

@jigargandhi
Copy link
Member Author

sure,

Signed-off-by: jigargandhi <jigarr.gandhi@gmail.com>
Signed-off-by: jigargandhi <jigarr.gandhi@gmail.com>
@Taction
Copy link
Member

Taction commented Mar 10, 2022

@jigargandhi can you please resolve conflicts?

@jigargandhi
Copy link
Member Author

Sure

@beiwei30
Copy link
Member

@jigargandhi would you pls. solve the conflict?

@beiwei30
Copy link
Member

@jigargandhi I tried to resolve conflicts with 7f56dcb but unfortunately I made some mistake to update the go.sum files. You may consider to re-run the following command to correct it:

make modtidy-all check-diff

Thanks.

Signed-off-by: jigargandhi <jigarr.gandhi@gmail.com>
@jigargandhi
Copy link
Member Author

@beiwei30 Done, only the FOSSA scan is failing because its not able to reach app.fossa.com, not sure why that would be the case

beiwei30
beiwei30 previously approved these changes May 9, 2022
Copy link
Member

@beiwei30 beiwei30 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Taction
Taction previously approved these changes May 21, 2022
Copy link
Member

@Taction Taction left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Taction
Copy link
Member

Taction commented May 21, 2022

@jigargandhi thanks for your awesome work and can you please resolve conflicts?

@jigargandhi jigargandhi dismissed stale reviews from Taction and beiwei30 via 6cf8054 May 23, 2022 06:01
Taction
Taction previously approved these changes May 26, 2022
@daixiang0
Copy link
Member

@jigargandhi please fix conflicts.

Signed-off-by: jigargandhi <jigarr.gandhi@gmail.com>
Signed-off-by: jigargandhi <jigarr.gandhi@gmail.com>
@codecov
Copy link

codecov bot commented Jun 20, 2022

Codecov Report

Merging #1455 (b7fb34a) into master (4322a22) will increase coverage by 0.25%.
The diff coverage is 22.89%.

@@            Coverage Diff             @@
##           master    #1455      +/-   ##
==========================================
+ Coverage   36.59%   36.85%   +0.25%     
==========================================
  Files         177      180       +3     
  Lines       16222    16321      +99     
==========================================
+ Hits         5937     6015      +78     
+ Misses       9617     9611       -6     
- Partials      668      695      +27     
Impacted Files Coverage Δ
authentication/azure/auth.go 38.12% <0.00%> (ø)
...indings/azure/servicebusqueues/servicebusqueues.go 2.02% <0.00%> (-8.67%) ⬇️
bindings/redis/redis.go 18.18% <0.00%> (-2.88%) ⬇️
bindings/zeebe/client.go 27.27% <ø> (ø)
bindings/zeebe/command/command.go 87.50% <ø> (ø)
bindings/zeebe/command/complete_job.go 64.70% <ø> (ø)
bindings/zeebe/command/create_instance.go 77.77% <ø> (ø)
bindings/zeebe/command/update_job_retries.go 71.42% <ø> (ø)
bindings/zeebe/jobworker/jobworker.go 11.34% <ø> (ø)
pubsub/azure/servicebus/message.go 48.10% <0.00%> (+1.75%) ⬆️
... and 34 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 55888c0...b7fb34a. Read the comment docs.

@dapr-bot
Copy link
Collaborator

This pull request has been automatically marked as stale because it has not had activity in the last 30 days. It will be closed in 7 days if no further activity occurs. Please feel free to give a status update now, ping for review, or re-open when it's ready. Thank you for your contributions!

@dapr-bot dapr-bot added the stale label Jul 20, 2022
@dapr-bot
Copy link
Collaborator

This pull request has been automatically closed because it has not had activity in the last 37 days. Please feel free to give a status update now, ping for review, or re-open when it's ready. Thank you for your contributions!

@dapr-bot dapr-bot closed this Jul 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Proposal] Provide alternative service resolution mechanism besides mdns
7 participants