-
Notifications
You must be signed in to change notification settings - Fork 463
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added local component which scans processes every 30 seconds and cach… #1455
Added local component which scans processes every 30 seconds and cach… #1455
Conversation
…es info Signed-off-by: jigargandhi <jigarr.gandhi@gmail.com>
Signed-off-by: jigargandhi <jigarr.gandhi@gmail.com>
@jigargandhi can you please resolve conflicts? |
sure, |
Signed-off-by: jigargandhi <jigarr.gandhi@gmail.com>
Signed-off-by: jigargandhi <jigarr.gandhi@gmail.com>
@jigargandhi can you please resolve conflicts? |
Sure |
@jigargandhi would you pls. solve the conflict? |
@jigargandhi I tried to resolve conflicts with 7f56dcb but unfortunately I made some mistake to update the go.sum files. You may consider to re-run the following command to correct it: make modtidy-all check-diff Thanks. |
Signed-off-by: jigargandhi <jigarr.gandhi@gmail.com>
@beiwei30 Done, only the FOSSA scan is failing because its not able to reach app.fossa.com, not sure why that would be the case |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@jigargandhi thanks for your awesome work and can you please resolve conflicts? |
Signed-off-by: jigargandhi <jigarr.gandhi@gmail.com>
@jigargandhi please fix conflicts. |
Signed-off-by: jigargandhi <jigarr.gandhi@gmail.com>
Signed-off-by: jigargandhi <jigarr.gandhi@gmail.com>
Codecov Report
@@ Coverage Diff @@
## master #1455 +/- ##
==========================================
+ Coverage 36.59% 36.85% +0.25%
==========================================
Files 177 180 +3
Lines 16222 16321 +99
==========================================
+ Hits 5937 6015 +78
+ Misses 9617 9611 -6
- Partials 668 695 +27
Continue to review full report at Codecov.
|
This pull request has been automatically marked as stale because it has not had activity in the last 30 days. It will be closed in 7 days if no further activity occurs. Please feel free to give a status update now, ping for review, or re-open when it's ready. Thank you for your contributions! |
This pull request has been automatically closed because it has not had activity in the last 37 days. Please feel free to give a status update now, ping for review, or re-open when it's ready. Thank you for your contributions! |
Description
Created a local name resolution component that does parsing of command line arguments to daprd/daprd.exe to identify different dapr instances.
Issue reference
We strive to have all PR being opened based on an issue, where the problem or feature have been discussed prior to implementation.
Please reference the issue this PR will close: dapr/dapr#3256
PR review comments from #1340 are fixed here.
Checklist
Please make sure you've completed the relevant tasks for this PR, out of the following list: