Local file-based name resolver with SQLite #3178
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: ItalyPaleAle <43508+ItalyPaleAle@users.noreply.github.com>
Signed-off-by: ItalyPaleAle <43508+ItalyPaleAle@users.noreply.github.com>
|
All cert tests are failing because the APIs changed and the pinned runtime needs to be updated. Usual problem :) However nothing changed here that would impact cert tests |
Signed-off-by: ItalyPaleAle <43508+ItalyPaleAle@users.noreply.github.com>
ItalyPaleAle
commented
Oct 14, 2023
Co-authored-by: Josh van Leeuwen <me@joshvanl.dev> Signed-off-by: Alessandro (Ale) Segala <43508+ItalyPaleAle@users.noreply.github.com>
Signed-off-by: ItalyPaleAle <43508+ItalyPaleAle@users.noreply.github.com>
Signed-off-by: ItalyPaleAle <43508+ItalyPaleAle@users.noreply.github.com>
Signed-off-by: ItalyPaleAle <43508+ItalyPaleAle@users.noreply.github.com>
5 tasks
See dapr#3179 Signed-off-by: ItalyPaleAle <43508+ItalyPaleAle@users.noreply.github.com>
Signed-off-by: ItalyPaleAle <43508+ItalyPaleAle@users.noreply.github.com>
Signed-off-by: ItalyPaleAle <43508+ItalyPaleAle@users.noreply.github.com>
Signed-off-by: ItalyPaleAle <43508+ItalyPaleAle@users.noreply.github.com>
JoshVanL
suggested changes
Oct 16, 2023
Signed-off-by: ItalyPaleAle <43508+ItalyPaleAle@users.noreply.github.com>
Signed-off-by: ItalyPaleAle <43508+ItalyPaleAle@users.noreply.github.com>
DeepanshuA
reviewed
Oct 25, 2023
| return err | ||
| } | ||
|
|
||
| // Show a warning if SQLite is configured with an in-memory DB |
There was a problem hiding this comment.
Do you think IsMemory should be allowed, as Service Invocation across different Apps, a basic use case, will not work?
Or is this development just for development scenario?
There was a problem hiding this comment.
I would not disable it outright, although yes, it kind of defeats the point of svc invocation across multiple apps (but can be used to test an app invoking itself). We also use that for unit testing.
Signed-off-by: ItalyPaleAle <43508+ItalyPaleAle@users.noreply.github.com>
Signed-off-by: Alessandro (Ale) Segala <43508+ItalyPaleAle@users.noreply.github.com>
|
If these new unit tests are slow we might want to move them to be some sort of pseudo certification tests. |
berndverst
approved these changes
Nov 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1380
Will fix (when runtime PR is merged) dapr/dapr#3256
Addresses a longstanding request to have an alternative name resolver component for local development, for situations where mDNS can't be used (and even in those situations, a local name resolver is more convenient for local development).
As discussed in #1380, this is implemented with SQLite, which is fast and efficient.
PR includes tests implemented via unit tests, since we don't have an infrastructure for writing conformance or certification tests for name resolvers.