Fixes first-write-wins with SQLite and MySQL #3207
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dapr#3159 introduced a regression that caused sets with first-write-wins fail if the table was empty The issue was due to a "FROM" statement in the CTE that should not have been there. Also improved how the SQLite component detects etag failures when FWW is used Signed-off-by: ItalyPaleAle <43508+ItalyPaleAle@users.noreply.github.com>
|
Great find |
yaron2
reviewed
Nov 2, 2023
yaron2
approved these changes
Nov 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#3159 introduced a regression that caused sets with first-write-wins fail if the table was empty
The issue was due to a "FROM" statement in the CTE that should not have been there.
Also improved how the SQLite component detects etag failures when FWW is used