Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AWS S3 Binding - Add Content-Type in the metadata request #3216

Merged
merged 4 commits into from Nov 9, 2023

Conversation

luigirende
Copy link
Contributor

Description

With this PR is possible add the Content-Type header when creates the object in the storage

Issue reference

We strive to have all PR being opened based on an issue, where the problem or feature have been discussed prior to implementation.

Please reference the issue this PR will close: #[issue number]

Checklist

Please make sure you've completed the relevant tasks for this PR, out of the following list:

  • Code compiles correctly
  • Created/updated tests
  • Extended the documentation / Created issue in the https://github.com/dapr/docs/ repo: dapr/docs#[issue number]

@luigirende luigirende requested review from a team as code owners November 8, 2023 16:30
Copy link
Contributor

@ItalyPaleAle ItalyPaleAle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bindings/aws/s3/s3.go Outdated Show resolved Hide resolved
bindings/aws/s3/s3.go Outdated Show resolved Hide resolved
@luigirende
Copy link
Contributor Author

Hi @ItalyPaleAle, i've just updated the code from your suggestions and signed-off the commit. Let me know if it's okey

@berndverst
Copy link
Member

@luigirende the "sign-off" is not applied to all commits.

To add your Signed-off-by line to every commit in this branch:

Ensure you have a local copy of your branch by checking out the pull request locally via command line.
In your local branch, run: git rebase HEAD~3 --signoff
Force push your changes to overwrite the branch: git push --force-with-lease origin main

luiren and others added 3 commits November 8, 2023 20:26
Signed-off-by: luigirende <luigirende@gmail.com>
Co-authored-by: Alessandro (Ale) Segala <43508+ItalyPaleAle@users.noreply.github.com>
Signed-off-by: luigirende <luigirende@gmail.com>
Co-authored-by: Alessandro (Ale) Segala <43508+ItalyPaleAle@users.noreply.github.com>
Signed-off-by: luigirende <luigirende@gmail.com>
Signed-off-by: luiren <luigirende@gmail.com>
Signed-off-by: luigirende <luigirende@gmail.com>
@ItalyPaleAle
Copy link
Contributor

@luigirende the linter is reporting some issues

Signed-off-by: luigirende <luigirende@gmail.com>
@luigirende
Copy link
Contributor Author

luigirende commented Nov 9, 2023

@ItalyPaleAle there are 2 issues on test task, I don't know how to fix them.

@ItalyPaleAle
Copy link
Contributor

@ItalyPaleAle there are 2 issues on test task, I don't know how to fix them.

Thanks for fixing the linter errors! Those are unrelated - some tests are flaky

@ItalyPaleAle ItalyPaleAle added this pull request to the merge queue Nov 9, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to no response for status checks Nov 9, 2023
@ItalyPaleAle ItalyPaleAle merged commit 8fe74b1 into dapr:main Nov 9, 2023
85 of 87 checks passed
berndverst pushed a commit to berndverst/components-contrib that referenced this pull request Nov 9, 2023
Signed-off-by: luigirende <luigirende@gmail.com>
Signed-off-by: luiren <luigirende@gmail.com>
Signed-off-by: Alessandro (Ale) Segala <43508+ItalyPaleAle@users.noreply.github.com>
Co-authored-by: luiren <luigi.rende@assistdigital.com>
Co-authored-by: Alessandro (Ale) Segala <43508+ItalyPaleAle@users.noreply.github.com>
berndverst pushed a commit to berndverst/components-contrib that referenced this pull request Nov 9, 2023
Signed-off-by: luigirende <luigirende@gmail.com>
Signed-off-by: luiren <luigirende@gmail.com>
Signed-off-by: Alessandro (Ale) Segala <43508+ItalyPaleAle@users.noreply.github.com>
Co-authored-by: luiren <luigi.rende@assistdigital.com>
Co-authored-by: Alessandro (Ale) Segala <43508+ItalyPaleAle@users.noreply.github.com>
@berndverst
Copy link
Member

Thanks again for this.

In the future please open an issue for discussion before making a PR and allow for maintainers or other Dapr users to leave comments. Or make a PR for an issue which has already been open for some time (and then link to that issue in your PR).

@ItalyPaleAle ItalyPaleAle added this to the v1.13 milestone Nov 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants