New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
AWS S3 Binding - Add Content-Type in the metadata request #3216
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please fix the DCO failure: https://docs.dapr.io/contributing/contributing-overview/#developer-certificate-of-origin-signing-your-work
b694d2e
to
19bdb1e
Compare
Hi @ItalyPaleAle, i've just updated the code from your suggestions and signed-off the commit. Let me know if it's okey |
@luigirende the "sign-off" is not applied to all commits. To add your Signed-off-by line to every commit in this branch: Ensure you have a local copy of your branch by checking out the pull request locally via command line. |
Signed-off-by: luigirende <luigirende@gmail.com>
Co-authored-by: Alessandro (Ale) Segala <43508+ItalyPaleAle@users.noreply.github.com> Signed-off-by: luigirende <luigirende@gmail.com>
Co-authored-by: Alessandro (Ale) Segala <43508+ItalyPaleAle@users.noreply.github.com> Signed-off-by: luigirende <luigirende@gmail.com> Signed-off-by: luiren <luigirende@gmail.com> Signed-off-by: luigirende <luigirende@gmail.com>
@luigirende the linter is reporting some issues |
Signed-off-by: luigirende <luigirende@gmail.com>
@ItalyPaleAle there are 2 issues on test task, I don't know how to fix them. |
Thanks for fixing the linter errors! Those are unrelated - some tests are flaky |
Signed-off-by: luigirende <luigirende@gmail.com> Signed-off-by: luiren <luigirende@gmail.com> Signed-off-by: Alessandro (Ale) Segala <43508+ItalyPaleAle@users.noreply.github.com> Co-authored-by: luiren <luigi.rende@assistdigital.com> Co-authored-by: Alessandro (Ale) Segala <43508+ItalyPaleAle@users.noreply.github.com>
Signed-off-by: luigirende <luigirende@gmail.com> Signed-off-by: luiren <luigirende@gmail.com> Signed-off-by: Alessandro (Ale) Segala <43508+ItalyPaleAle@users.noreply.github.com> Co-authored-by: luiren <luigi.rende@assistdigital.com> Co-authored-by: Alessandro (Ale) Segala <43508+ItalyPaleAle@users.noreply.github.com>
Thanks again for this. In the future please open an issue for discussion before making a PR and allow for maintainers or other Dapr users to leave comments. Or make a PR for an issue which has already been open for some time (and then link to that issue in your PR). |
Description
With this PR is possible add the Content-Type header when creates the object in the storage
Issue reference
We strive to have all PR being opened based on an issue, where the problem or feature have been discussed prior to implementation.
Please reference the issue this PR will close: #[issue number]
Checklist
Please make sure you've completed the relevant tasks for this PR, out of the following list: