GCP Pubsub: cache topics #3241
Merged
GCP Pubsub: cache topics #3241
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: sadath-12 <sadathsadu2002@gmail.com>
Signed-off-by: sadath-12 <sadathsadu2002@gmail.com>
JoshVanL
suggested changes
Nov 20, 2023
ItalyPaleAle
requested changes
Nov 20, 2023
Signed-off-by: sadath-12 <sadathsadu2002@gmail.com>
|
@ItalyPaleAle , Does the structure I used now fine ? supporting cache invalidation |
Signed-off-by: sadath-12 <sadathsadu2002@gmail.com>
JoshVanL
suggested changes
Nov 24, 2023
Signed-off-by: sadath-12 <sadathsadu2002@gmail.com>
Signed-off-by: sadath-12 <sadathsadu2002@gmail.com>
Signed-off-by: sadath-12 <sadathsadu2002@gmail.com>
ItalyPaleAle
requested changes
Nov 29, 2023
Co-authored-by: Alessandro (Ale) Segala <43508+ItalyPaleAle@users.noreply.github.com> Signed-off-by: syedsadath-17 <90619459+sadath-12@users.noreply.github.com>
Signed-off-by: sadath-12 <sadathsadu2002@gmail.com>
|
/ok-to-test |
Complete Build MatrixThe build status is currently not updated here. Please visit the action run below directly. Commit ref: 0faf8da |
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
|
/ok-to-test |
Complete Build MatrixThe build status is currently not updated here. Please visit the action run below directly. Commit ref: 8fb335c |
Components certification testCommit ref: 8fb335c ❌ Some certification tests failedThese tests failed:
|
Components conformance testCommit ref: 8fb335c ✅ All conformance tests passedAll tests have reported a successful status |
Signed-off-by: Alessandro (Ale) Segala <43508+ItalyPaleAle@users.noreply.github.com>
ItalyPaleAle
previously approved these changes
Dec 6, 2023
|
Thank you @sadath-12 ! |
auto-merge was automatically disabled
December 6, 2023 18:13
Head branch was pushed to by a user without write access
ItalyPaleAle
approved these changes
Dec 6, 2023
10 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Please explain the changes you've made
Now we don't call ensureTopic function unnecessarily , we cache it and continue if its called before
Issue reference
We strive to have all PR being opened based on an issue, where the problem or feature have been discussed prior to implementation.
Please reference the issue this PR will close: #2539
Checklist
Please make sure you've completed the relevant tasks for this PR, out of the following list: