Kafka: Add message key and other metadata as metadata in consumer #3289
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
passuied
force-pushed
the
feature/kafka-pubsub-consumer-key
branch
from
37ab449
to
ba601df
Compare
passuied
changed the title
passuied
changed the title
passuied
force-pushed
the
feature/kafka-pubsub-consumer-key
branch
3 times, most recently
from
66722b7
to
0b87d21
Compare
Signed-off-by: Patrick Assuied <patrick.assuied@elationhealth.com>
passuied
force-pushed
the
feature/kafka-pubsub-consumer-key
branch
from
0b87d21
to
dc695c0
Compare
|
@dapr/maintainers-components-contrib, @berndverst, @yaron2, First contribution. Waiting for approval... What's the typical SLA? |
passuied
commented
Jan 3, 2024
| @@ -28,6 +28,11 @@ import ( | |||
|
|
|||
| const ( | |||
| key = "partitionKey" | |||
| keyMetadataKey = "__key" | |||
There was a problem hiding this comment.
Please note I chose the __ prefix convention to reduce chances of collision with other headers... The __ prefix is a common convention in kafka connect. Though I could make the prefix more specific (like __kafka.timestamp for instance
ItalyPaleAle
approved these changes
Jan 3, 2024
ItalyPaleAle
changed the title
passuied
added a commit
to passuied/components-contrib
that referenced
this pull request
Jan 3, 2024
…pr#3289) Signed-off-by: Patrick Assuied <patrick.assuied@elationhealth.com>
3 tasks
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Pass Message Key and other message metadata as metadata in Kafka.pubsub consumer.
Currently, only message value is passed to endpoint.
Issue reference
Fixes #2213
Checklist