Kafka: fix context use in AWS IAM auth #3305
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Fabian Martinez <46371672+famarting@users.noreply.github.com>
ItalyPaleAle
requested changes
Jan 5, 2024
Signed-off-by: Fabian Martinez <46371672+famarting@users.noreply.github.com>
ItalyPaleAle
reviewed
Jan 8, 2024
ItalyPaleAle
changed the title
ItalyPaleAle
previously approved these changes
Jan 8, 2024
eunicecompra
approved these changes
Jan 8, 2024
auto-merge was automatically disabled
January 9, 2024 08:57
Head branch was pushed to by a user without write access
ItalyPaleAle
approved these changes
Jan 9, 2024
eunicecompra
pushed a commit
to eunicecompra/components-contrib
that referenced
this pull request
Jan 9, 2024
Signed-off-by: Fabian Martinez <46371672+famarting@users.noreply.github.com> Signed-off-by: Alessandro (Ale) Segala <43508+ItalyPaleAle@users.noreply.github.com> Co-authored-by: Yaron Schneider <schneider.yaron@live.com> Co-authored-by: Alessandro (Ale) Segala <43508+ItalyPaleAle@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The Kafka awsiam authentication type did not actually work since it was making incorrect use of the context that was passed to the Init function
As it can be seen here https://github.com/dapr/dapr/blob/70e3f699793bb138d927079682261999b010e40e/pkg/runtime/processor/processor.go#L381 dapr cancels the context passed to Init once it finishes, making this context not suitable for background tasks such as using the aws sdk to get the kafka credentials at runtime...
Issue reference
We strive to have all PR being opened based on an issue, where the problem or feature have been discussed prior to implementation.
Please reference the issue this PR will close: #[issue number]
Checklist
Please make sure you've completed the relevant tasks for this PR, out of the following list: