Change failure threshold int32 -> int

Signed-off-by: joshvanl <me@joshvanl.dev>
dapr · Nov 17, 2023 · d10a483 · d10a483
1 parent 1c49bca
commit d10a483
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 7 deletions.
diff --git a/pkg/actors/health/health.go b/pkg/actors/health/health.go
@@ -27,7 +27,7 @@ import (
 
 const (
 	defaultInitialDelay           = time.Second * 1
-	defaultFailureThreshold       = int32(2)
+	defaultFailureThreshold       = 2
 	defaultRequestTimeout         = time.Second * 2
 	defaultHealthyStateInterval   = time.Second * 3
 	defaultUnHealthyStateInterval = time.Second / 2
@@ -41,7 +41,7 @@ type options struct {
 	address                string
 	initialDelay           time.Duration
 	requestTimeout         time.Duration
-	failureThreshold       int32
+	failureThreshold       int
 	healthyStateInterval   time.Duration
 	unhealthyStateInterval time.Duration
 	successStatusCode      int
@@ -61,7 +61,7 @@ type Checker struct {
 	address                string
 	initialDelay           time.Duration
 	requestTimeout         time.Duration
-	failureThreshold       int32
+	failureThreshold       int
 	healthyStateInterval   time.Duration
 	unhealthyStateInterval time.Duration
 	successStatusCode      int
@@ -192,7 +192,7 @@ func (c *Checker) doHealthyStateCheck(ctx context.Context) {
 	ticker := c.clock.NewTicker(c.healthyStateInterval)
 	defer ticker.Stop()
 
-	var failureCount int32
+	var failureCount int
 	for {
 		select {
 		case <-ctx.Done():
@@ -256,7 +256,7 @@ func WithInitialDelay(delay time.Duration) Option {
 }
 
 // WithFailureThreshold sets the failure threshold for the health check.
-func WithFailureThreshold(threshold int32) Option {
+func WithFailureThreshold(threshold int) Option {
 	return func(o *options) {
 		o.failureThreshold = threshold
 	}

diff --git a/pkg/actors/health/health_test.go b/pkg/actors/health/health_test.go
@@ -39,7 +39,7 @@ func TestApplyOptions(t *testing.T) {
 		)
 		require.NoError(t, err)
 
-		assert.Equal(t, defaultFailureThreshold, int32(2))
+		assert.Equal(t, defaultFailureThreshold, 2)
 		assert.Equal(t, defaultInitialDelay, time.Second)
 		assert.Equal(t, defaultHealthyStateInterval, time.Second*3)
 		assert.Equal(t, defaultUnHealthyStateInterval, time.Second/2)
@@ -68,7 +68,7 @@ func TestApplyOptions(t *testing.T) {
 		require.NoError(t, err)
 
 		assert.Equal(t, "http://localhost:8081", checker.address)
-		assert.Equal(t, int32(10), checker.failureThreshold)
+		assert.Equal(t, 10, checker.failureThreshold)
 		assert.Equal(t, time.Second*11, checker.initialDelay)
 		assert.Equal(t, time.Second*12, checker.healthyStateInterval)
 		assert.Equal(t, time.Second*15, checker.unhealthyStateInterval)