Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove deprecated RenameReminder methods #6711

Closed
ItalyPaleAle opened this issue Jul 21, 2023 · 4 comments
Closed

Remove deprecated RenameReminder methods #6711

ItalyPaleAle opened this issue Jul 21, 2023 · 4 comments
Assignees
@ItalyPaleAle
Labels
breaking-change This is a breaking change pinned
Milestone
v1.13

Comments

@ItalyPaleAle
Copy link
Contributor

Spin-off from #6669 (comment)

The "RenameReminder" method was deprecated in Dapr 1.9 because it is not safe, and has been showing a warning ever since: #4957

We should remove this deprecated method and simplify our actors subsystem
@ItalyPaleAle ItalyPaleAle added the breaking-change This is a breaking change label Jul 21, 2023
@ItalyPaleAle ItalyPaleAle added this to the v1.12 milestone Jul 21, 2023
@ItalyPaleAle ItalyPaleAle mentioned this issue Jul 21, 2023
Merged
7 tasks
@dapr-bot
Copy link
Collaborator

This issue has been automatically marked as stale because it has not had activity in the last 60 days. It will be closed in the next 7 days unless it is tagged (pinned, good first issue, help wanted or triaged/resolved) or other activity occurs. Thank you for your contributions.

@dapr-bot dapr-bot added the stale Issues and PRs without response label Sep 19, 2023
ItalyPaleAle added a commit to ItalyPaleAle/dapr that referenced this issue Sep 19, 2023
@ItalyPaleAle
Remove deprecated RenameActorReminder methods
72e1fec 
Fixes dapr#6711

Signed-off-by: ItalyPaleAle <43508+ItalyPaleAle@users.noreply.github.com>
ItalyPaleAle added a commit to ItalyPaleAle/dapr that referenced this issue Sep 19, 2023
@ItalyPaleAle
Remove deprecated RenameActorReminder methods
1c24de5 
Fixes dapr#6711

Signed-off-by: ItalyPaleAle <43508+ItalyPaleAle@users.noreply.github.com>
@ItalyPaleAle ItalyPaleAle mentioned this issue Sep 19, 2023
Merged
@mukundansundar mukundansundar added pinned and removed stale Issues and PRs without response labels Sep 20, 2023
@mukundansundar mukundansundar modified the milestones: v1.12, v1.13 Sep 20, 2023
@mukundansundar
Copy link
Contributor

to track any SDK changes needed.

@mukundansundar
Copy link
Contributor

@dapr/maintainers-python-sdk @dapr/maintainers-js-sdk @dapr/maintainers-java-sdk @dapr/maintainers-dotnet-sdk do we need any changes with respect to this? Mostly the rest of the SDKs like rust and C++ would only need a proto update.

@shubham1172
Copy link
Member

@mukundansundar SDK issues were created already, we closed the JS-SDK one, please see dapr/js-sdk#534

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ItalyPaleAle ItalyPaleAle

Labels
breaking-change This is a breaking change pinned
Projects
None yet
Milestone
v1.13
Development

No branches or pull requests
4 participants
@ItalyPaleAle @shubham1172 @dapr-bot @mukundansundar