Remove deprecated RenameActorReminder methods #6945
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes dapr#6711 Signed-off-by: ItalyPaleAle <43508+ItalyPaleAle@users.noreply.github.com>
ItalyPaleAle
added
breaking-change
This comment was marked as resolved.
This comment was marked as resolved.
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## master #6945 +/- ##
==========================================
+ Coverage 64.84% 64.95% +0.10%
==========================================
Files 228 228
Lines 20823 20731 -92
==========================================
- Hits 13503 13466 -37
+ Misses 6189 6143 -46
+ Partials 1131 1122 -9
☔ View full report in Codecov by Sentry. |
Signed-off-by: ItalyPaleAle <43508+ItalyPaleAle@users.noreply.github.com>
|
/ok-to-test |
Dapr E2E testCommit ref: d1e2508 ✅ Build succeeded for linux/amd64
✅ Build succeeded for windows/amd64
✅ Infrastructure deployed
✅ Tests succeeded on windows/amd64
✅ Tests succeeded on linux/amd64
|
mukundansundar
approved these changes
Sep 20, 2023
There was a problem hiding this comment.
lgtm
@dapr/maintainers-dapr merging this based off of #6669 (comment)
|
@ItalyPaleAle Please create a tracking issue if this breaking change requires a change in SDKs as well. |
|
Letting #6711 remain open for any changes that are needed in SDKs. |
This was referenced Oct 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes the issue #6711
Methods were deprecated in 1.9 and slated to be removed from 1.13.