metrics: grpc_server_status label missing for grpc server latency metric

[famarting]

In what area(s)?

/area runtime

What version of Dapr?

edge: b6540a1

Expected Behavior

if the label grpc_server_status is expected to be included in the grpc server latency metric, it should be properly recorded and returned by the prometheus metrics format.

Actual Behavior

the grpc metric grpc.io/server/server_latency uses the label grpc_server_status when recording data, but it does not actually define that label, resulting on the label actually not being exposed in the prometheus format.

Looking at the code, the current behavior is either the expected one or this has been a small mistake that no one has ever noticed:

Here we can see the metric is defined but the status label is not included https://github.com/dapr/dapr/blob/master/pkg/diagnostics/grpc_monitoring.go#L119

However, here https://github.com/dapr/dapr/blob/master/pkg/diagnostics/grpc_monitoring.go#L158 we can see that when recording data the label is passed

Steps to Reproduce the Problem

Release Note

RELEASE NOTE:
FIX missing grpc_server_status label on dapr_grpc_io_server_server_latency metric

[jerinthomas1404]

Hi @famarting / @artursouza , Can I take up this issue?
I would like to contribute to dapr

[yaron2]

Hi @famarting / @artursouza , Can I take up this issue? I would like to contribute to dapr

Sure thing, I've assigned you

[famarting]

Hi @famarting / @artursouza , Can I take up this issue? I would like to contribute to dapr

Yes, of course. Thank you 😄

[sp6370]

@jerinthomas1404 Are you still working on the issue?

[mendaxjerin]

@jerinthomas1404 Are you still working on the issue?

Got busy with some other task

[sp6370]

No worries! I was just curious if this was up for grabs. 😅

[ckcd]

Can I take up this issue?

[dapr-bot]

👋 @ckcd, my apologies but I can't perform this action for you because your username is not in the allowlist in the file .github/scripts/dapr_bot.js.

[yaron2]

Closed via #7255.

Thanks @ckcd