Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix missing label on server_server_latency metric #7255

Merged
merged 4 commits into from Dec 5, 2023

Conversation

ckcd
Copy link
Contributor

@ckcd ckcd commented Nov 29, 2023

Description

Fix missing grpc_server_status label on dapr_grpc_io_server_server_latency metric.

Issue reference

#7045

Checklist

Please make sure you've completed the relevant tasks for this PR, out of the following list:

  • Code compiles correctly
  • Created/updated tests
  • Unit tests passing
  • End-to-end tests passing

Signed-off-by: Kun Chang <curtis@mail.ustc.edu.cn>
@ckcd ckcd requested review from a team as code owners November 29, 2023 11:27
@ckcd
Copy link
Contributor Author

ckcd commented Nov 30, 2023

Seems like we need a ok-to-test label, @dapr-bot

@dapr-bot
Copy link
Collaborator

👋 @ckcd, my apologies but I can't perform this action for you because your username is not in the allowlist in the file .github/scripts/dapr_bot.js.

@ckcd
Copy link
Contributor Author

ckcd commented Nov 30, 2023

@famarting @ItalyPaleAle PTAL, thanks.

@ckcd
Copy link
Contributor Author

ckcd commented Dec 4, 2023

@RyanLettieri @ItalyPaleAle @artursouza @JoshVanL PTAL, thanks.

@RyanLettieri
Copy link
Contributor

/ok-to-test

@dapr-bot
Copy link
Collaborator

dapr-bot commented Dec 4, 2023

Dapr E2E test

🔗 Link to Action run

Commit ref: e6bc047

✅ Build succeeded for linux/amd64

  • Image tag: dapre2e7503a7b12fl
  • Test image tag: dapre2e7503a7b12fl

✅ Infrastructure deployed

Cluster Resource group name Azure region
Linux Dapr-E2E-dapre2e7503a7b12fl westus3
Windows Dapr-E2E-dapre2e7503a7b12fw westus3
Linux/arm64 Dapr-E2E-dapre2e7503a7b12fla eastus

✅ Build succeeded for windows/amd64

  • Image tag: dapre2e7503a7b12fw
  • Test image tag: dapre2e7503a7b12fw

✅ Tests succeeded on windows/amd64

  • Image tag: dapre2e7503a7b12fw
  • Test image tag: dapre2e7503a7b12fw

✅ Tests succeeded on linux/amd64

  • Image tag: dapre2e7503a7b12fl
  • Test image tag: dapre2e7503a7b12fl

Copy link
Member

@daixiang0 daixiang0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@daixiang0
Copy link
Member

@ckcd thanks for your contribution!

@daixiang0 daixiang0 merged commit 743d120 into dapr:master Dec 5, 2023
8 of 9 checks passed
@JoshVanL JoshVanL added this to the v1.13 milestone Feb 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants