Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support priorityClass assignment in Helm charts #7103

Closed
masmontanas opened this issue Oct 26, 2023 · 5 comments · Fixed by #7395
Closed

Support priorityClass assignment in Helm charts #7103

masmontanas opened this issue Oct 26, 2023 · 5 comments · Fixed by #7395
Assignees
Labels
Milestone

Comments

@masmontanas
Copy link

In what area(s)?

/area runtime

/area operator

/area placement

/area docs

/area test-and-release

Describe the feature

It would be great to support priorityClass assignments for all helm charts. When running in kubernetes, there are times when our clusters are undergoing node replacement, clusters are facing capacity constraints, or workloads are recovering from a catastrophic event -- we rely heavily on various priority class assignments to ensure certain workloads are prioritized. Since dapr is required for nominal functionality, it's imperative that dapr pods are scheduled with a high priority and are able to preempt other pods -- if dapr's sidecar-injection isn't available nothing is operational.

Release Note

RELEASE NOTE:

@Rob623
Copy link

Rob623 commented Dec 17, 2023

+1 on this feature request

1 similar comment
@ggattegno
Copy link

+1 on this feature request

@Viktorsubota
Copy link
Contributor

+1, It looks really useful

@yaron2 yaron2 added the good first issue Good for newcomers label Jan 8, 2024
@yaron2
Copy link
Member

yaron2 commented Jan 8, 2024

If anyone is interested in opening a PR for this that would be welcome

@masmontanas
Copy link
Author

Thanks @yaron2 , @Viktorsubota will likely put in a PR tomorrow.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants