Issues 7103 add priority class to helm #7395

Viktorsubota · 2024-01-17T17:05:47Z

Description

This PR adds the priorityClassName field to the Helm chart to provide the value to all Dapr workloads.

Issue reference

Please reference the issue this PR will close: #7103

Checklist

Please make sure you've completed the relevant tasks for this PR, out of the following list:

Code compiles correctly
Created/updated tests
Unit tests passing
End-to-end tests passing
Extended the documentation / Created issue in the https://github.com/dapr/docs/ repo: dapr/docs#[issue number]
Specification has been updated / Created issue in the https://github.com/dapr/docs/ repo: dapr/docs#[issue number]
Provided sample for the feature / Created issue in the https://github.com/dapr/docs/ repo: dapr/docs#[issue number]

* Updating protos Signed-off-by: Shivam Kumar <shivamkm07@gmail.com> * enable recursive terminate/purge Signed-off-by: Shivam Kumar <shivamkm07@gmail.com> * Updating dtf-go Signed-off-by: Shivam Kumar <shivamkm07@gmail.com> * updating contrib Signed-off-by: Shivam Kumar <shivamkm07@gmail.com> * Correct proto generated files Signed-off-by: Shivam Kumar <shivamkm07@gmail.com> * update comment Signed-off-by: Shivam Kumar <shivamkm07@gmail.com> * implementing getOrchestrationRuntimeState Signed-off-by: Shivam Kumar <shivamkm07@gmail.com> * Adding unit tests Signed-off-by: Shivam Kumar <shivamkm07@gmail.com> * make modtidy-all Signed-off-by: Shivam Kumar <shivamkm07@gmail.com> * Adding recursive option in query parameter Signed-off-by: Shivam Kumar <shivamkm07@gmail.com> * Adding integration test for workflow Signed-off-by: Shivam Kumar <shivamkm07@gmail.com> * fix bug in Creating sub-orchestrations Signed-off-by: Shivam Kumar <shivamkm07@gmail.com> * Setting recursive/terminate purge to default and adding tests for same Signed-off-by: Shivam Kumar <shivamkm07@gmail.com> * linter fixes Signed-off-by: Shivam Kumar <shivamkm07@gmail.com> * Removing fix from this PR Signed-off-by: Shivam Kumar <shivamkm07@gmail.com> * renaming to Signed-off-by: Shivam Kumar <shivamkm07@gmail.com> * linter fixes Signed-off-by: Shivam Kumar <shivamkm07@gmail.com> --------- Signed-off-by: Shivam Kumar <shivamkm07@gmail.com> Co-authored-by: Mukundan Sundararajan <65565396+mukundansundar@users.noreply.github.com> Co-authored-by: Loong Dai <long.dai@intel.com> Co-authored-by: Dapr Bot <56698301+dapr-bot@users.noreply.github.com> Signed-off-by: Viktor Subota <viktor.subota@c.delinea.com>

Signed-off-by: Viktor Subota <viktor.subota@c.delinea.com>

codecov · 2024-01-17T17:26:13Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (33d49ff) 62.22% compared to head (b27d5ab) 62.35%.

❗ Current head b27d5ab differs from pull request most recent head 5843c12. Consider uploading reports for the commit 5843c12 to get more accurate results

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #7395      +/-   ##
==========================================
+ Coverage   62.22%   62.35%   +0.13%     
==========================================
  Files         240      240              
  Lines       22135    22154      +19     
==========================================
+ Hits        13774    13815      +41     
+ Misses       7210     7183      -27     
- Partials     1151     1156       +5

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

* Cascade terminate/Purge Workflow Support (dapr#7340) * Updating protos Signed-off-by: Shivam Kumar <shivamkm07@gmail.com> * enable recursive terminate/purge Signed-off-by: Shivam Kumar <shivamkm07@gmail.com> * Updating dtf-go Signed-off-by: Shivam Kumar <shivamkm07@gmail.com> * updating contrib Signed-off-by: Shivam Kumar <shivamkm07@gmail.com> * Correct proto generated files Signed-off-by: Shivam Kumar <shivamkm07@gmail.com> * update comment Signed-off-by: Shivam Kumar <shivamkm07@gmail.com> * implementing getOrchestrationRuntimeState Signed-off-by: Shivam Kumar <shivamkm07@gmail.com> * Adding unit tests Signed-off-by: Shivam Kumar <shivamkm07@gmail.com> * make modtidy-all Signed-off-by: Shivam Kumar <shivamkm07@gmail.com> * Adding recursive option in query parameter Signed-off-by: Shivam Kumar <shivamkm07@gmail.com> * Adding integration test for workflow Signed-off-by: Shivam Kumar <shivamkm07@gmail.com> * fix bug in Creating sub-orchestrations Signed-off-by: Shivam Kumar <shivamkm07@gmail.com> * Setting recursive/terminate purge to default and adding tests for same Signed-off-by: Shivam Kumar <shivamkm07@gmail.com> * linter fixes Signed-off-by: Shivam Kumar <shivamkm07@gmail.com> * Removing fix from this PR Signed-off-by: Shivam Kumar <shivamkm07@gmail.com> * renaming to Signed-off-by: Shivam Kumar <shivamkm07@gmail.com> * linter fixes Signed-off-by: Shivam Kumar <shivamkm07@gmail.com> --------- Signed-off-by: Shivam Kumar <shivamkm07@gmail.com> Co-authored-by: Mukundan Sundararajan <65565396+mukundansundar@users.noreply.github.com> Co-authored-by: Loong Dai <long.dai@intel.com> Co-authored-by: Dapr Bot <56698301+dapr-bot@users.noreply.github.com> Signed-off-by: Viktor Subota <viktor.subota@c.delinea.com> * Add priorityClassName parameter to Helm chart Signed-off-by: Viktor Subota <viktor.subota@c.delinea.com> * Add priorityClassName to README doc Signed-off-by: Viktor Subota <viktor.subota@c.delinea.com> --------- Signed-off-by: Shivam Kumar <shivamkm07@gmail.com> Signed-off-by: Viktor Subota <viktor.subota@c.delinea.com> Co-authored-by: Shivam Kumar <shivamkm07@gmail.com> Co-authored-by: Mukundan Sundararajan <65565396+mukundansundar@users.noreply.github.com> Co-authored-by: Loong Dai <long.dai@intel.com> Co-authored-by: Dapr Bot <56698301+dapr-bot@users.noreply.github.com> Co-authored-by: Viktor Subota <viktor.subota@c.delinea.com>

This reverts commit 1e4287e.

* Cascade terminate/Purge Workflow Support (dapr#7340) * Updating protos Signed-off-by: Shivam Kumar <shivamkm07@gmail.com> * enable recursive terminate/purge Signed-off-by: Shivam Kumar <shivamkm07@gmail.com> * Updating dtf-go Signed-off-by: Shivam Kumar <shivamkm07@gmail.com> * updating contrib Signed-off-by: Shivam Kumar <shivamkm07@gmail.com> * Correct proto generated files Signed-off-by: Shivam Kumar <shivamkm07@gmail.com> * update comment Signed-off-by: Shivam Kumar <shivamkm07@gmail.com> * implementing getOrchestrationRuntimeState Signed-off-by: Shivam Kumar <shivamkm07@gmail.com> * Adding unit tests Signed-off-by: Shivam Kumar <shivamkm07@gmail.com> * make modtidy-all Signed-off-by: Shivam Kumar <shivamkm07@gmail.com> * Adding recursive option in query parameter Signed-off-by: Shivam Kumar <shivamkm07@gmail.com> * Adding integration test for workflow Signed-off-by: Shivam Kumar <shivamkm07@gmail.com> * fix bug in Creating sub-orchestrations Signed-off-by: Shivam Kumar <shivamkm07@gmail.com> * Setting recursive/terminate purge to default and adding tests for same Signed-off-by: Shivam Kumar <shivamkm07@gmail.com> * linter fixes Signed-off-by: Shivam Kumar <shivamkm07@gmail.com> * Removing fix from this PR Signed-off-by: Shivam Kumar <shivamkm07@gmail.com> * renaming to Signed-off-by: Shivam Kumar <shivamkm07@gmail.com> * linter fixes Signed-off-by: Shivam Kumar <shivamkm07@gmail.com> --------- Signed-off-by: Shivam Kumar <shivamkm07@gmail.com> Co-authored-by: Mukundan Sundararajan <65565396+mukundansundar@users.noreply.github.com> Co-authored-by: Loong Dai <long.dai@intel.com> Co-authored-by: Dapr Bot <56698301+dapr-bot@users.noreply.github.com> Signed-off-by: Viktor Subota <viktor.subota@c.delinea.com> * Add priorityClassName parameter to Helm chart Signed-off-by: Viktor Subota <viktor.subota@c.delinea.com> * Add priorityClassName to README doc Signed-off-by: Viktor Subota <viktor.subota@c.delinea.com> --------- Signed-off-by: Shivam Kumar <shivamkm07@gmail.com> Signed-off-by: Viktor Subota <viktor.subota@c.delinea.com> Co-authored-by: Shivam Kumar <shivamkm07@gmail.com> Co-authored-by: Mukundan Sundararajan <65565396+mukundansundar@users.noreply.github.com> Co-authored-by: Loong Dai <long.dai@intel.com> Co-authored-by: Dapr Bot <56698301+dapr-bot@users.noreply.github.com> Co-authored-by: Viktor Subota <viktor.subota@c.delinea.com> Signed-off-by: Elena Kolevska <elena@kolevska.com>

This reverts commit 1e4287e. Signed-off-by: Elena Kolevska <elena@kolevska.com>

Viktorsubota requested review from a team as code owners January 17, 2024 17:05

shivamkm07 and others added 3 commits January 17, 2024 18:17

Add priorityClassName parameter to Helm chart

3b9fc65

Signed-off-by: Viktor Subota <viktor.subota@c.delinea.com>

Add priorityClassName to README doc

d9574d8

Signed-off-by: Viktor Subota <viktor.subota@c.delinea.com>

Viktorsubota force-pushed the issues-7103-add-prioritt-class-to-helm branch from 6388e85 to d9574d8 Compare January 17, 2024 17:19

Merge branch 'master' into issues-7103-add-prioritt-class-to-helm

db89918

artursouza approved these changes Jan 17, 2024

View reviewed changes

yaron2 changed the title ~~Issues 7103 add prioritt class to helm~~ Issues 7103 add priority class to helm Jan 17, 2024

Viktorsubota added 3 commits January 17, 2024 23:34

Merge branch 'master' into issues-7103-add-prioritt-class-to-helm

b27d5ab

Merge branch 'master' into issues-7103-add-prioritt-class-to-helm

acf7c95

Merge branch 'master' into issues-7103-add-prioritt-class-to-helm

5843c12

yaron2 merged commit 21095cb into dapr:master Jan 19, 2024
18 of 20 checks passed

elena-kolevska added a commit to elena-kolevska/dapr that referenced this pull request Jan 24, 2024

Revert "Issues 7103 add priority class to helm (dapr#7395)"

e2b3d8c

This reverts commit 1e4287e.

elena-kolevska added a commit to elena-kolevska/dapr that referenced this pull request Jan 25, 2024

Revert "Issues 7103 add priority class to helm (dapr#7395)"

038d33b

This reverts commit 1e4287e. Signed-off-by: Elena Kolevska <elena@kolevska.com>

JoshVanL added this to the v1.13 milestone Feb 12, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Issues 7103 add priority class to helm #7395

Issues 7103 add priority class to helm #7395

Viktorsubota commented Jan 17, 2024 •

edited by mukundansundar

codecov bot commented Jan 17, 2024 •

edited

Issues 7103 add priority class to helm #7395

Issues 7103 add priority class to helm #7395

Conversation

Viktorsubota commented Jan 17, 2024 • edited by mukundansundar

Description

Issue reference

Checklist

codecov bot commented Jan 17, 2024 • edited

Codecov Report

Viktorsubota commented Jan 17, 2024 •

edited by mukundansundar

codecov bot commented Jan 17, 2024 •

edited