Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade Go to 1.21 #7228

Closed
JoshVanL opened this issue Nov 22, 2023 · 4 comments · Fixed by #7262
Closed

Upgrade Go to 1.21 #7228

JoshVanL opened this issue Nov 22, 2023 · 4 comments · Fixed by #7262
Assignees
Milestone

Comments

@JoshVanL
Copy link
Contributor

This includes updating the Go ref in go.mod as well as selected Go versions in .github workflows.

Note that, due to the change in import and init func ordering changing in Go 1.21, the grpc proxy proto codec is no longer registered after the grpc internal proto codec definition, meaning the dapr custom definition will not be registered and will cause errors. The custom proto needs to be either re-registered at runtime, or change its name in order to fix this.

There is likely other errors which need resolving when upgrading to 1.21.

@JoshVanL
Copy link
Contributor Author

/assign

@JoshVanL JoshVanL mentioned this issue Nov 22, 2023
31 tasks
@JoshVanL JoshVanL added this to the v1.13 milestone Nov 27, 2023
@JoshVanL JoshVanL added the P0 label Nov 27, 2023
@mukundansundar
Copy link
Contributor

CLI upgrade PR dapr/cli#1331

@berndverst
Copy link
Member

@JoshVanL you mentioned you'll do the runtime Go 1.21 migration correct?

I completed the contrib Go 1.21 migration: dapr/components-contrib#3251

We will not be able to pin contrib anymore until runtime is also migrated, so it's high priority now.

You may want to use the updated linter configuration from here: https://github.com/dapr/components-contrib/blob/main/.golangci.yml

For consistency, please switch to Golangci-lint v1.55.2 which we now use in contrib. You will need to switch linter version for Go 1.21 support.

@JoshVanL
Copy link
Contributor Author

@berndverst that's right yeah I'll be taking this ticket and working on it now. Thanks for the info, this is a great help 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Development

Successfully merging a pull request may close this issue.

3 participants