Updates Go to 1.21, golangci-lint to 1.55.2 #7262
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Note that, due to the change in import and init func ordering changing in Go 1.21, the grpc proxy proto codec is no longer registered after the grpc internal proto codec definition, meaning the dapr custom definition will not be registered and will cause errors. The custom proto needs to be either re-registered at runtime, or change its name in order to fix this. This is done in the gRPC object, and handler_test.go TestMain. Signed-off-by: joshvanl <me@joshvanl.dev>
|
See also the changes made in contrib for the linter's config. Configuration for one linter (depguard) has changed format. There are also some new linters that you may want to disable. Ideally the config should be similar in contrib and runtime: https://github.com/dapr/components-contrib/pull/3251/files#diff-6179837f7df53a6f05c522b6b7bb566d484d5465d9894fb04910dd08bb40dcc9 |
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #7262 +/- ##
==========================================
- Coverage 64.55% 64.53% -0.02%
==========================================
Files 225 225
Lines 21067 21070 +3
==========================================
- Hits 13599 13597 -2
- Misses 6303 6306 +3
- Partials 1165 1167 +2 ☔ View full report in Codecov by Sentry. |
ItalyPaleAle
requested changes
Dec 1, 2023
Signed-off-by: joshvanl <me@joshvanl.dev>
Signed-off-by: joshvanl <me@joshvanl.dev>
ItalyPaleAle
approved these changes
Dec 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note that, due to the change in import and init func ordering changing in Go 1.21, the grpc proxy proto codec is no longer registered after the grpc internal proto codec definition, meaning the dapr custom definition will not be registered and will cause errors. The custom proto needs to be either re-registered at runtime, or change its name in order to fix this. This is done in the gRPC object, and handler_test.go TestMain.
closes #7228