Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Error immediately when metrics export server fails #7021

Merged
merged 3 commits into from Oct 13, 2023

Conversation

JoshVanL
Copy link
Contributor

The metrics exporter will currently now immediately error if the server listener fails, for example if the port is already being used, and will therefore silently hang.

PR makes the metrics exporter fail immediately and return.

Signed-off-by: joshvanl <me@joshvanl.dev>
@JoshVanL JoshVanL requested review from a team as code owners October 11, 2023 10:55
@JoshVanL JoshVanL added the autoupdate DaprBot will keep the Pull Request up to date with master branch label Oct 11, 2023
@codecov
Copy link

codecov bot commented Oct 11, 2023

Codecov Report

Attention: 6 lines in your changes are missing coverage. Please review.

Comparison is base (648ac48) 64.86% compared to head (19260d6) 64.87%.
Report is 1 commits behind head on master.

❗ Current head 19260d6 differs from pull request most recent head 45099bc. Consider uploading reports for the commit 45099bc to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #7021      +/-   ##
==========================================
+ Coverage   64.86%   64.87%   +0.01%     
==========================================
  Files         231      230       -1     
  Lines       20840    20784      -56     
==========================================
- Hits        13518    13484      -34     
+ Misses       6186     6166      -20     
+ Partials     1136     1134       -2     
Files Coverage Δ
pkg/metrics/exporter.go 31.81% <0.00%> (-3.19%) ⬇️

... and 12 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mukundansundar mukundansundar added this to the v1.13 milestone Oct 11, 2023
@yaron2 yaron2 merged commit b6540a1 into dapr:master Oct 13, 2023
17 of 20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
autoupdate DaprBot will keep the Pull Request up to date with master branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants