New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Metadata API: report actor runtime status #7040
Metadata API: report actor runtime status #7040
Conversation
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #7040 +/- ##
==========================================
- Coverage 64.62% 64.55% -0.08%
==========================================
Files 225 225
Lines 21023 21050 +27
==========================================
+ Hits 13587 13588 +1
- Misses 6278 6299 +21
- Partials 1158 1163 +5 ☔ View full report in Codecov by Sentry. |
Signed-off-by: ItalyPaleAle <43508+ItalyPaleAle@users.noreply.github.com>
Signed-off-by: ItalyPaleAle <43508+ItalyPaleAle@users.noreply.github.com>
2f2b669
to
5644f7c
Compare
Signed-off-by: ItalyPaleAle <43508+ItalyPaleAle@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
/ok-to-test |
/test-sdk-all |
/test-version-skew |
Dapr E2E testCommit ref: 2c8162b ✅ Build succeeded for linux/amd64
✅ Infrastructure deployed
✅ Build succeeded for windows/amd64
❌ Tests failed on windows/amd64Please check the logs for details on the error. ✅ Tests succeeded on linux/amd64
|
Dapr SDK Go testCommit ref: 2c8162b ✅ Go SDK tests passed |
Dapr SDK Python testCommit ref: 2c8162b ✅ Python SDK tests passed |
Dapr SDK Java testCommit ref: 2c8162b ❌ Java SDK tests failedPlease check the logs for details on the error. |
Dapr Version Skew test (control-plane-master - 1.12.0)Commit ref: 2c8162b ✅ Version Skew tests passed |
Dapr Version Skew test (dapr-sidecar-master - 1.12.0)Commit ref: 2c8162b ❌ Version Skew tests failedPlease check the logs for details on the error. |
Dapr SDK JS testCommit ref: 2c8162b ✅ JS SDK tests passed |
…ctor-status Signed-off-by: ItalyPaleAle <43508+ItalyPaleAle@users.noreply.github.com>
/ok-to-test |
Dapr E2E testCommit ref: 3e49978 ✅ Build succeeded for linux/amd64
✅ Infrastructure deployed
✅ Build succeeded for windows/amd64
✅ Tests succeeded on windows/amd64
✅ Tests succeeded on linux/amd64
|
…ctor-status Signed-off-by: ItalyPaleAle <43508+ItalyPaleAle@users.noreply.github.com>
* Metadata API: report actor runtime status Signed-off-by: ItalyPaleAle <43508+ItalyPaleAle@users.noreply.github.com> * Added integration tests Signed-off-by: ItalyPaleAle <43508+ItalyPaleAle@users.noreply.github.com> * Changed per review feedback Signed-off-by: ItalyPaleAle <43508+ItalyPaleAle@users.noreply.github.com> * Address review feedback 1 Signed-off-by: ItalyPaleAle <43508+ItalyPaleAle@users.noreply.github.com> * Address review feedback 2 Signed-off-by: ItalyPaleAle <43508+ItalyPaleAle@users.noreply.github.com> * Renamed to WithInMemoryActorStateStore Signed-off-by: ItalyPaleAle <43508+ItalyPaleAle@users.noreply.github.com> * Added comments Signed-off-by: ItalyPaleAle <43508+ItalyPaleAle@users.noreply.github.com> --------- Signed-off-by: ItalyPaleAle <43508+ItalyPaleAle@users.noreply.github.com> Signed-off-by: Mukundan Sundararajan <65565396+mukundansundar@users.noreply.github.com> Co-authored-by: Dapr Bot <56698301+dapr-bot@users.noreply.github.com> Co-authored-by: Mukundan Sundararajan <65565396+mukundansundar@users.noreply.github.com>
Updates the metadata API to include additional information on the actor runtime and its status. This is helpful to understand if the actor runtime has completed the initialization, whether the actor runtime is an actor host or just an actor client, and whether the connection with the placement service is active.
Examples (only added data is shown):
While the (actor) runtime is initializing (i.e. before the request for /dapr/config has been completed):
Actor runtime has initialized and the app is hosting actors:
Actor runtime has initialized as actor client only (e.g. there's no "actorStateStore" configured):
Actor runtime has initialized but connection to placement is down:
Actor runtime is disabled (no
placement-host-address
option)The
actorRuntime.activeActors
property is an alias of the pre-existingactors
property, which contains a count of active actors. The old property is deprecated but not removed for backwards-compatibility (so the data is included twice, at least for now).