New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix subscription match nil format. #7067
Conversation
Signed-off-by: zhangchao <zchao9100@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM overall, please see my comments (and fix the linter!)
Signed-off-by: zhangchao <zchao9100@gmail.com>
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #7067 +/- ##
==========================================
+ Coverage 64.92% 64.96% +0.03%
==========================================
Files 231 231
Lines 20855 20857 +2
==========================================
+ Hits 13541 13550 +9
+ Misses 6182 6167 -15
- Partials 1132 1140 +8
☔ View full report in Codecov by Sentry. |
Signed-off-by: zhangchao <zchao9100@gmail.com>
Signed-off-by: zhangchao <zchao9100@gmail.com>
@JoshVanL Thanks for the example, added. |
Description
Metadata API returns rule match value to be empty when it is not defined.
Issue reference
Please reference the issue this PR will close: #7049
Checklist
Please make sure you've completed the relevant tasks for this PR, out of the following list: