Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix subscription match nil format. #7067

Merged
merged 4 commits into from Oct 21, 2023

Conversation

Taction
Copy link
Member

@Taction Taction commented Oct 20, 2023

Description

Metadata API returns rule match value to be empty when it is not defined.

Issue reference

Please reference the issue this PR will close: #7049

Checklist

Please make sure you've completed the relevant tasks for this PR, out of the following list:

Signed-off-by: zhangchao <zchao9100@gmail.com>
@Taction Taction requested review from a team as code owners October 20, 2023 15:02
Copy link
Contributor

@ItalyPaleAle ItalyPaleAle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM overall, please see my comments (and fix the linter!)

pkg/runtime/pubsub/subscription.go Outdated Show resolved Hide resolved
pkg/grpc/universalapi/api_metadata.go Outdated Show resolved Hide resolved
pkg/runtime/pubsub/subscriptions_test.go Outdated Show resolved Hide resolved
Signed-off-by: zhangchao <zchao9100@gmail.com>
@codecov
Copy link

codecov bot commented Oct 21, 2023

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (014d5d8) 64.92% compared to head (56b4f61) 64.96%.
Report is 6 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #7067      +/-   ##
==========================================
+ Coverage   64.92%   64.96%   +0.03%     
==========================================
  Files         231      231              
  Lines       20855    20857       +2     
==========================================
+ Hits        13541    13550       +9     
+ Misses       6182     6167      -15     
- Partials     1132     1140       +8     
Files Coverage Δ
pkg/grpc/universalapi/api_metadata.go 92.75% <100.00%> (ø)
pkg/expr/expr.go 77.77% <0.00%> (-3.62%) ⬇️

... and 5 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@JoshVanL
Copy link
Contributor

@Taction Please can you add an integration test to cover this? Here is an example of an existing metadata test.

Signed-off-by: zhangchao <zchao9100@gmail.com>
Signed-off-by: zhangchao <zchao9100@gmail.com>
@Taction
Copy link
Member Author

Taction commented Oct 21, 2023

@JoshVanL Thanks for the example, added.

@yaron2 yaron2 merged commit e09bd30 into dapr:master Oct 21, 2023
19 of 22 checks passed
@JoshVanL JoshVanL added this to the v1.13 milestone Feb 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Metadata API produces invalid subscription rule match value when it's nil
4 participants