-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix wrong service invocation type in http tracing #7088
Conversation
Thanks for this! I believe when #6919 is merged, it should supersede this issue and fix this bug too. Let's get that merged first :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let’s wait on #6919 which should address this issue at the root.
@RayOnFire if you can please pull the master branch version, build a |
|
||
var dbType string | ||
var componentType string | ||
|
||
appId := r.Header.Get("dapr-app-id") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
appId := r.Header.Get("dapr-app-id") | |
appID := r.Header.Get("dapr-app-id") |
In the current master branch, we changed how tracing works significantly. Could you please make sure this PR is still needed? |
Ping @RayOnFire |
This pull request has been automatically marked as stale because it has not had activity in the last 60 days. It will be closed in 7 days if no further activity occurs. Please feel free to give a status update now, ping for review, or re-open when it's ready. Thank you for your contributions! |
Ping @RayOnFire |
Hi, sorry for the late reply. I think in the current master branch, this PR is no longer needed. Thank you for your comment & code review! |
Description
If request contains header
dapr-app-id
, this PR will treat it as a service invocation.Issue reference
Please reference the issue this PR will close: #[7085]
Checklist
Please make sure you've completed the relevant tasks for this PR, out of the following list: