Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix wrong service invocation type in http tracing #7088

Closed

Conversation

RayOnFire
Copy link

Description

If request contains header dapr-app-id, this PR will treat it as a service invocation.

Issue reference

Please reference the issue this PR will close: #[7085]

Checklist

Please make sure you've completed the relevant tasks for this PR, out of the following list:

@RayOnFire RayOnFire requested review from a team as code owners October 24, 2023 01:19
@ItalyPaleAle
Copy link
Contributor

Thanks for this!

I believe when #6919 is merged, it should supersede this issue and fix this bug too. Let's get that merged first :)

Copy link
Contributor

@ItalyPaleAle ItalyPaleAle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let’s wait on #6919 which should address this issue at the root.

@yaron2
Copy link
Member

yaron2 commented Oct 24, 2023

@RayOnFire if you can please pull the master branch version, build a daprd binary and see if the issue is now resolved, that would help a lot.


var dbType string
var componentType string

appId := r.Header.Get("dapr-app-id")
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
appId := r.Header.Get("dapr-app-id")
appID := r.Header.Get("dapr-app-id")

@ItalyPaleAle
Copy link
Contributor

In the current master branch, we changed how tracing works significantly. Could you please make sure this PR is still needed?

@yaron2
Copy link
Member

yaron2 commented Nov 16, 2023

Ping @RayOnFire

@dapr-bot
Copy link
Collaborator

This pull request has been automatically marked as stale because it has not had activity in the last 60 days. It will be closed in 7 days if no further activity occurs. Please feel free to give a status update now, ping for review, or re-open when it's ready. Thank you for your contributions!

@dapr-bot dapr-bot added the stale Issues and PRs without response label Jan 15, 2024
@yaron2
Copy link
Member

yaron2 commented Jan 15, 2024

Ping @RayOnFire

@dapr-bot dapr-bot removed the stale Issues and PRs without response label Jan 15, 2024
@RayOnFire
Copy link
Author

Hi, sorry for the late reply. I think in the current master branch, this PR is no longer needed. Thank you for your comment & code review!

@RayOnFire RayOnFire closed this Jan 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants