Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Workflow] Make workflow engine configurable (and other improvements) #7090
[Workflow] Make workflow engine configurable (and other improvements) #7090
Changes from all commits
708af2c
e29ec26
60401b1
8edf866
abaaf67
3583dfe
d773e3b
77f5a19
cf7d32d
5e54218
59193c5
78f7441
050d036
6a8913c
6c797b5
e32647e
9c01990
6b77b7f
9ed79ee
bf86875
dfeca70
f05ffc7
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Check warning on line 135 in pkg/config/configuration.go
Codecov / codecov/patch
pkg/config/configuration.go#L134-L135
Check warning on line 137 in pkg/config/configuration.go
Codecov / codecov/patch
pkg/config/configuration.go#L137
Check warning on line 142 in pkg/config/configuration.go
Codecov / codecov/patch
pkg/config/configuration.go#L141-L142
Check warning on line 144 in pkg/config/configuration.go
Codecov / codecov/patch
pkg/config/configuration.go#L144
Check warning on line 625 in pkg/config/configuration.go
Codecov / codecov/patch
pkg/config/configuration.go#L623-L625
Check warning on line 588 in pkg/runtime/runtime.go
Codecov / codecov/patch
pkg/runtime/runtime.go#L588
Check warning on line 127 in pkg/runtime/wfengine/activity.go
Codecov / codecov/patch
pkg/runtime/wfengine/activity.go#L126-L127
Check warning on line 130 in pkg/runtime/wfengine/activity.go
Codecov / codecov/patch
pkg/runtime/wfengine/activity.go#L129-L130
Check warning on line 134 in pkg/runtime/wfengine/activity.go
Codecov / codecov/patch
pkg/runtime/wfengine/activity.go#L134
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Removed this TODO since this work was already done in v1.11.
Check warning on line 199 in pkg/runtime/wfengine/activity.go
Codecov / codecov/patch
pkg/runtime/wfengine/activity.go#L199