Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add robustness to monitoring of workflow URLs. #7094

Merged

Conversation

philliphoff
Copy link
Contributor

Description

Issue reference

Please reference the issue this PR will close: #7087

Checklist

Please make sure you've completed the relevant tasks for this PR, out of the following list:

@philliphoff philliphoff requested review from a team as code owners October 24, 2023 20:28
@ItalyPaleAle
Copy link
Contributor

LGTM but can you rebase this on release-1.12? Since for master, the issue will be fixed by #6723

@yaron2
Copy link
Member

yaron2 commented Oct 24, 2023

I think we can do with this fix (or the other PR) for master only, not entirely sure this needs to go into a patch release as Workflows is beta and this isn't a showstopper to using the APIs

@ItalyPaleAle
Copy link
Contributor

I think we can do with this fix (or the other PR) for master only,

In master, please don't merge this as it will just cause more conflicts on #6723 which then will need to be fixed

Workflows is beta and this isn't a showstopper to using the APIs

While that's true, it's causing daprd to panic so it could even be considered a DoS

@philliphoff
Copy link
Contributor Author

I'll rebase it to release-1.12.

@philliphoff philliphoff force-pushed the philliphoff-http-monitoring-fix branch from 5049964 to 91d7feb Compare October 24, 2023 23:14
@philliphoff philliphoff changed the base branch from master to release-1.12 October 24, 2023 23:15
Signed-off-by: Phillip Hoff <phillip@orst.edu>
Copy link
Contributor

@ItalyPaleAle ItalyPaleAle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but it's up to the maintainers to accept this

Copy link
Member

@daixiang0 daixiang0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approve, wait for DCO fix.

@philliphoff
Copy link
Contributor Author

@daixiang0 I'm not sure what GH is complaining about; it's a single commit that contains the sign off (for me), as best I can tell.

@ItalyPaleAle
Copy link
Contributor

@philliphoff i think this PR is in a broken state after the rebase. Could you try force-pushing your commit again?

@philliphoff philliphoff force-pushed the philliphoff-http-monitoring-fix branch from 91d7feb to 32733b6 Compare October 30, 2023 18:04
@JoshVanL JoshVanL mentioned this pull request Oct 31, 2023
17 tasks
@mukundansundar mukundansundar added automerge Allows DaprBot to automerge and update PR if all approvals are in place autoupdate DaprBot will keep the Pull Request up to date with master branch labels Nov 2, 2023
@mukundansundar
Copy link
Contributor

@philliphoff can you fix the lint error that is seen here?

@mukundansundar mukundansundar removed the automerge Allows DaprBot to automerge and update PR if all approvals are in place label Nov 2, 2023
Signed-off-by: Phillip Hoff <phillip@orst.edu>
Copy link

codecov bot commented Nov 2, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (c1e5a0a) 64.76% compared to head (5c37764) 64.73%.

Additional details and impacted files
@@               Coverage Diff                @@
##           release-1.12    #7094      +/-   ##
================================================
- Coverage         64.76%   64.73%   -0.03%     
================================================
  Files               231      231              
  Lines             20940    20942       +2     
================================================
- Hits              13561    13557       -4     
- Misses             6250     6252       +2     
- Partials           1129     1133       +4     
Files Coverage Δ
pkg/diagnostics/http_monitoring.go 79.37% <100.00%> (+0.26%) ⬆️

... and 7 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@artursouza artursouza merged commit 5c80afb into dapr:release-1.12 Nov 2, 2023
20 of 22 checks passed
@philliphoff philliphoff deleted the philliphoff-http-monitoring-fix branch November 3, 2023 16:14
JoshVanL pushed a commit to JoshVanL/dapr that referenced this pull request Nov 20, 2023
* Add robustness to monitoring of workflow URLs.

Signed-off-by: Phillip Hoff <phillip@orst.edu>

* Update formatting.

Signed-off-by: Phillip Hoff <phillip@orst.edu>

---------

Signed-off-by: Phillip Hoff <phillip@orst.edu>
Co-authored-by: Mukundan Sundararajan <65565396+mukundansundar@users.noreply.github.com>
@JoshVanL JoshVanL added this to the v1.13 milestone Feb 12, 2024
cicoyle pushed a commit to cicoyle/dapr that referenced this pull request May 24, 2024
* Add robustness to monitoring of workflow URLs.

Signed-off-by: Phillip Hoff <phillip@orst.edu>

* Update formatting.

Signed-off-by: Phillip Hoff <phillip@orst.edu>

---------

Signed-off-by: Phillip Hoff <phillip@orst.edu>
Co-authored-by: Mukundan Sundararajan <65565396+mukundansundar@users.noreply.github.com>
Signed-off-by: Cassandra Coyle <cassie@diagrid.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
autoupdate DaprBot will keep the Pull Request up to date with master branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Dapr Runtime panic for malformed/unexpected workflow URLs
7 participants