-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add robustness to monitoring of workflow URLs. #7094
Add robustness to monitoring of workflow URLs. #7094
Conversation
LGTM but can you rebase this on release-1.12? Since for master, the issue will be fixed by #6723 |
I think we can do with this fix (or the other PR) for master only, not entirely sure this needs to go into a patch release as Workflows is beta and this isn't a showstopper to using the APIs |
In master, please don't merge this as it will just cause more conflicts on #6723 which then will need to be fixed
While that's true, it's causing daprd to panic so it could even be considered a DoS |
I'll rebase it to |
5049964
to
91d7feb
Compare
Signed-off-by: Phillip Hoff <phillip@orst.edu>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM but it's up to the maintainers to accept this
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approve, wait for DCO fix.
@daixiang0 I'm not sure what GH is complaining about; it's a single commit that contains the sign off (for me), as best I can tell. |
@philliphoff i think this PR is in a broken state after the rebase. Could you try force-pushing your commit again? |
91d7feb
to
32733b6
Compare
@philliphoff can you fix the lint error that is seen here? |
Signed-off-by: Phillip Hoff <phillip@orst.edu>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## release-1.12 #7094 +/- ##
================================================
- Coverage 64.76% 64.73% -0.03%
================================================
Files 231 231
Lines 20940 20942 +2
================================================
- Hits 13561 13557 -4
- Misses 6250 6252 +2
- Partials 1129 1133 +4
☔ View full report in Codecov by Sentry. |
* Add robustness to monitoring of workflow URLs. Signed-off-by: Phillip Hoff <phillip@orst.edu> * Update formatting. Signed-off-by: Phillip Hoff <phillip@orst.edu> --------- Signed-off-by: Phillip Hoff <phillip@orst.edu> Co-authored-by: Mukundan Sundararajan <65565396+mukundansundar@users.noreply.github.com>
* Add robustness to monitoring of workflow URLs. Signed-off-by: Phillip Hoff <phillip@orst.edu> * Update formatting. Signed-off-by: Phillip Hoff <phillip@orst.edu> --------- Signed-off-by: Phillip Hoff <phillip@orst.edu> Co-authored-by: Mukundan Sundararajan <65565396+mukundansundar@users.noreply.github.com> Signed-off-by: Cassandra Coyle <cassie@diagrid.io>
Description
Issue reference
Please reference the issue this PR will close: #7087
Checklist
Please make sure you've completed the relevant tasks for this PR, out of the following list: