Placement: Adds authorization to ReportDaprStatus #7112
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PR updates the placement server to authorize ReportDaprStatus client requests when in mTLS mode. In mTLS mode, placement will verify that the requested host update has the same app ID as the client's identity. There is currently no concept of namespacing in placement, so apps across namespaces with the same app ID are considered to have the same identity, so different identities can share the same host pool across namespaces. Though today the actor subsystem is public across the cluster, and actors cannot invoke across namespaces. Signed-off-by: joshvanl <me@joshvanl.dev>
JoshVanL
added
the
autoupdate
ItalyPaleAle
approved these changes
Oct 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR updates the placement server to authorize ReportDaprStatus client requests when in mTLS mode. In mTLS mode, placement will verify that the requested host update has the same app ID as the client's identity.
There is currently no concept of namespacing in placement, so apps across namespaces with the same app ID are considered to have the same identity, so different identities can share the same host pool across namespaces. Though today the actor subsystem is public across the cluster, and actors cannot invoke across namespaces.