Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Grafana dashboards. #7121

Merged
merged 2 commits into from
Nov 4, 2023
Merged

Fix Grafana dashboards. #7121

merged 2 commits into from
Nov 4, 2023

Commits on Nov 3, 2023

  1. Fix Grafana dashboards. 

    The current grafana dashboards do not work in a fresh cluster where
prometheus and grafana are installed using helm following Dapr Docs
(see [1], [2]). They refer to metrics that are not available in
such install.

In short, based on bug-report from dapr/test-infra#204, the proposed
fix can be summed by:

```bash
sed -i \
    -e 's/\bkubernetes_name\b/service/g' \
    -e 's/\bkubernetes_namespace\b/namespace/g' \
    -e 's/\bkubernetes_node\b/node/g' \
    -e 's/\bkubernetes_pod_name\b/pod/g' \
    *.json
```

Additionally:

* Removes refresh rates smaller than 1 minute.
* Sets default interval range to 14 days in the past to now
* Sets default template values to match the longhaul clusters.

Fixes dapr#7120

[1]: https://docs.dapr.io/operations/observability/metrics/prometheus/#setup-prometheus-on-kubernetes
[2]: https://docs.dapr.io/operations/observability/metrics/grafana/#setup-on-kubernetes

Signed-off-by: Tiago Alves Macambira <tmacam@burocrata.org>
    @tmacam
    tmacam committed Nov 3, 2023
    Configuration menu
    Copy the full SHA
    d584415 View commit details
    Browse the repository at this point in the history

  2. Remove longhaul related settings. 

    Signed-off-by: Tiago Alves Macambira <tmacam@burocrata.org>
    @tmacam
    tmacam committed Nov 3, 2023
    Configuration menu
    Copy the full SHA
    a98f3f1 View commit details
    Browse the repository at this point in the history