Defining Workflow metrics #7152
Conversation
Signed-off-by: prateek041 <prateeksingh9741@gmail.com>
|
I have mentioned a few cc @shubham1172 |
Replied over the |
|
Thank you for being patient with me @shivamkm07. Sure, for any more conceptual doubts, I will ping you on discord. |
- Operations - Reminders - Execution Signed-off-by: prateek041 <prateeksingh9741@gmail.com>
Signed-off-by: prateek041 <prateeksingh9741@gmail.com>
- Create Workflow - Get Workflow - Purge Workflow - Add Events Signed-off-by: prateek041 <prateeksingh9741@gmail.com>
Signed-off-by: prateek041 <prateeksingh9741@gmail.com>
executions. Signed-off-by: prateek041 <prateeksingh9741@gmail.com>
|
@shivamkm07 please review. Also, there are many needless comments which I added for extra context, will remove them when the PR is ready. |
Signed-off-by: prateek041 <prateeksingh9741@gmail.com>
Signed-off-by: prateek041 <prateeksingh9741@gmail.com>
Signed-off-by: prateek041 <prateeksingh9741@gmail.com>
Signed-off-by: prateek041 <prateeksingh9741@gmail.com>
|
Can we include testing for these new metrics under this PR? |
| diagUtils.NewMeasureView(w.workflowOperationCount, []tag.Key{appIDKey, componentKey, namespaceKey, operationKey, statusKey}, view.Count()), | ||
| diagUtils.NewMeasureView(w.workflowOperationLatency, []tag.Key{appIDKey, componentKey, namespaceKey, operationKey, statusKey}, defaultLatencyDistribution), | ||
| diagUtils.NewMeasureView(w.workflowExecutionCount, []tag.Key{appIDKey, componentKey, namespaceKey, executionTypeKey, statusKey}, view.Count()), | ||
| diagUtils.NewMeasureView(w.workflowExecutionLatency, []tag.Key{appIDKey, componentKey, namespaceKey, executionTypeKey, statusKey}, defaultLatencyDistribution)) |
There was a problem hiding this comment.
I think we should have workflowName and activityName as well in this metric; else a common plotting won't make much sense - as different activities mayhave different expected latencies.
| "The number of successful/failed/recoverable workflow/activity executions.", | ||
| stats.UnitDimensionless), | ||
| workflowExecutionLatency: stats.Float64( | ||
| "runtime/workflow/execution/latency", |
There was a problem hiding this comment.
Should it be runtime/workflow/execution/latency and runtime/workflow/activity/execution/latency - differentiation would be there - and cardinality can also be reduced by removing executionTypeKey.
There was a problem hiding this comment.
Similarly, for workflow/execution/count metric as well
Co-authored-by: Mukundan Sundararajan <65565396+mukundansundar@users.noreply.github.com> Signed-off-by: Shivam Kumar <shivamkm07@gmail.com>
Signed-off-by: Shivam Kumar <shivamkm07@gmail.com>
Signed-off-by: Shivam Kumar <shivamkm07@gmail.com>
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #7152 +/- ##
==========================================
+ Coverage 64.42% 64.48% +0.05%
==========================================
Files 237 238 +1
Lines 21704 21814 +110
==========================================
+ Hits 13983 14066 +83
- Misses 6521 6536 +15
- Partials 1200 1212 +12 ☔ View full report in Codecov by Sentry. |
Signed-off-by: Shivam Kumar <shivamkm07@gmail.com>
Signed-off-by: Shivam Kumar <shivamkm07@gmail.com>
|
/ok-to-test |
|
/test-version-skew |
Dapr E2E testCommit ref: 0907987 ✅ Build succeeded for linux/amd64
✅ Infrastructure deployed
✅ Build succeeded for windows/amd64
❌ Tests failed on windows/amd64Please check the logs for details on the error. ❌ Tests failed on linux/amd64Please check the logs for details on the error. |
Dapr Version Skew e2e test (dapr-sidecar-master - 1.12.3)Commit ref: 0907987 ✅ Version Skew tests passed |
Dapr Version Skew e2e test (control-plane-master - 1.12.3)Commit ref: 0907987 ✅ Version Skew tests passed |
Dapr Version Skew integration test (dapr-sidecar-master - ull)Commit ref: 0907987 ❌ Version Skew tests failedPlease check the logs for details on the error. |
Dapr Version Skew integration test (control-plane-master - 1.12.3)Commit ref: 0907987 ❌ Version Skew tests failedPlease check the logs for details on the error. |
docs/development/dapr-metrics.md
Outdated
| * dapr_runtime_workflow_operation_count: The number of successful/failed workflow operation requests. | ||
| * dapr_runtime_workflow_operation_latency: The latencies of responses for workflow operation requests. | ||
| * dapr_runtime_workflow_execution_count: The number of successful/failed/recoverable workflow/activity executions. | ||
| * dapr_runtime_workflow_execution_latency: The total time taken to run a workflow/activity to completion. |
There was a problem hiding this comment.
nitpick: change this metric name
Signed-off-by: Shivam Kumar <shivamkm07@gmail.com>
Signed-off-by: Shivam Kumar <shivamkm07@gmail.com>
This comment has been minimized.
This comment has been minimized.
❌ Version Skew tests failedPlease check the logs for details on the error. |
Description
This pull request adds workflow metrics.
Issue reference
Will fix #7109
Checklist
Please make sure you've completed the relevant tasks for this PR, out of the following list: