Helm: add options to configure the Service resources #7153
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds options to configure, for each Service that is created: - The type (`ClusterIP`, the default, `LoadBalancer`, etc) _(not for placement)_ - Custom annotations - there was already an option to set annotations on deployments, but not on services Default values don't change, but just gives a few more options for users who have special environments. Signed-off-by: ItalyPaleAle <43508+ItalyPaleAle@users.noreply.github.com>
ItalyPaleAle
added
the
autoupdate
shubham1172
approved these changes
Nov 7, 2023
mukundansundar
approved these changes
Nov 7, 2023
|
/ok-to-test |
|
/version-skew-test |
Dapr E2E testCommit ref: e56526c ✅ Build succeeded for linux/amd64
✅ Infrastructure deployed
✅ Build succeeded for windows/amd64
✅ Tests succeeded on windows/amd64
✅ Tests succeeded on linux/amd64
|
|
/test-version-skew |
Dapr Version Skew test (control-plane-master - 1.12.0)Commit ref: e56526c ✅ Version Skew tests passed |
Dapr Version Skew test (dapr-sidecar-master - 1.12.0)Commit ref: e56526c ❌ Version Skew tests failedPlease check the logs for details on the error. |
mukundansundar
added
the
automerge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds options to configure, for each Service that is created:
ClusterIP, the default,LoadBalancer, etc) (not for placement, which doesn't allocate any IP for the service)Default values don't change, but just gives a few more options for users who have special environments.