Operator: do not patch the Subscription CRDs if the conversion webhooks are disabled #7154
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ks are disabled When running the operator with `ENABLE_WEBHOOKS=false`, which disables listening for the conversion webhooks, the operator should not be patching the CRDs Signed-off-by: ItalyPaleAle <43508+ItalyPaleAle@users.noreply.github.com>
|
Do we have a test to cover this case? |
We do not, and we do not have the infrastructure for creating tests for this (we do not have the ability to test different Helm options in our CI, for example) |
ItalyPaleAle
added
the
autoupdate
daixiang0
approved these changes
Nov 8, 2023
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #7154 +/- ##
==========================================
- Coverage 65.07% 64.95% -0.13%
==========================================
Files 221 221
Lines 20798 20803 +5
==========================================
- Hits 13534 13512 -22
- Misses 6125 6147 +22
- Partials 1139 1144 +5
☔ View full report in Codecov by Sentry. |
yaron2
approved these changes
Nov 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When running the operator with
ENABLE_WEBHOOKS=false, which disables listening for the conversion webhooks, the operator should not be patching the CRDs