Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enforce Component names to be unique #7195

Merged
merged 7 commits into from
Nov 21, 2023

Commits on Nov 15, 2023

  1. Enforce Component names to be unique

    Currently in standalone mode, it is possible to load multiple components
    with the same name but of different types. This is problematic as it can
    produce undefined behaviour in Daprd where global state indexed on
    Component name (like state encryption) can "leak" to another Component.
    It also makes it impossible to implement the hot reloader reconciler as
    that controller is level based, and without a single unique name to
    index on, the reconciler cannot determine which Components have been
    deleted/editted. It is also confusing to different requirements to
    Kubernetes whether a Component name _must_ be unique within a namespace.
    
    PR implements a check to ensure that Component names are unique. The
    component store implements a pending & lock mechanism to ensure that
    another Component of the same name cannot be added whilst another is
    initialising.
    
    Adds an integration test to ensure daprd errors when multiple Components
    with the same name are added.
    
    Signed-off-by: joshvanl <me@joshvanl.dev>
    JoshVanL committed Nov 15, 2023
    Configuration menu
    Copy the full SHA
    ab52bcb View commit details
    Browse the repository at this point in the history
  2. Linting

    Signed-off-by: joshvanl <me@joshvanl.dev>
    JoshVanL committed Nov 15, 2023
    Configuration menu
    Copy the full SHA
    9b21dd1 View commit details
    Browse the repository at this point in the history

Commits on Nov 16, 2023

  1. Configuration menu
    Copy the full SHA
    b0ea892 View commit details
    Browse the repository at this point in the history

Commits on Nov 20, 2023

  1. Ignore Kill error on integration exec process

    Signed-off-by: joshvanl <me@joshvanl.dev>
    JoshVanL committed Nov 20, 2023
    Configuration menu
    Copy the full SHA
    65f8c12 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    306916c View commit details
    Browse the repository at this point in the history

Commits on Nov 21, 2023

  1. Configuration menu
    Copy the full SHA
    8b569d8 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    4c100c4 View commit details
    Browse the repository at this point in the history